Skip to content

{bio}[GCCcore/6.4.0] biomart-perl v0.7_e6db561#6745

Merged
boegel merged 3 commits intoeasybuilders:developfrom
vanzod:20180821174336_new_pr_biomart-perl07_e6db561
Aug 23, 2018
Merged

{bio}[GCCcore/6.4.0] biomart-perl v0.7_e6db561#6745
boegel merged 3 commits intoeasybuilders:developfrom
vanzod:20180821174336_new_pr_biomart-perl07_e6db561

Conversation

@vanzod
Copy link
Copy Markdown
Member

@vanzod vanzod commented Aug 21, 2018

Requires #6744

@vanzod vanzod added the new label Aug 21, 2018
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Aug 21, 2018

Test report by @vanzod
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
cermis - Linux debian 9.4, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/2b759d00dbadb48a2b42e2391c2319fd for a full test report.

@vanzod vanzod added this to the 3.7.0 milestone Aug 22, 2018

postinstallcmds = [
'sed -ni "/<MartRegistry>/q;p" %s' % marturlloc,
'curl https://useast.ensembl.org/biomart/martservice?type=registry >> %s' % marturlloc,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzod Is this some kind of mirror? What does this do exactly?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why not do this via a patch file?

(we really need better support for runtime patching without relying on sed...)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file must be modified based on the content of that URL. I do not see how to do it from a patch...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, good point...

'curl https://useast.ensembl.org/biomart/martservice?type=registry >> %s' % marturlloc,
]

modloadmsg = "Copy the registry file locally from:\n%(installdir)s/conf/martURLLocation.xml\n\n"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally to where?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The executon of the BioMart Perl scripts requires this file to identify the source URLs for the data. The data is then cached in the same directory where the file is. Hence it needs to reside in a location where the user has write permission.
I will rephrase it.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 23, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2594.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/70b35481c03fc64d7c50f53459c49e75 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 23, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3110.skitty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/418f2ade461a2c03269fcda06a644a3a for a full test report.

boegel
boegel previously approved these changes Aug 23, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 23, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
gligar03.gligar.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9ce285a5aa828a5b1eaee483f8001c2c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 23, 2018

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2594.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/a2c135e1749737171f31fbae1239ef5d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 23, 2018

Going in, thanks @vanzod!

@boegel boegel merged commit 43b0bde into easybuilders:develop Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants