@jhale: a style remark (we try very hard to maintain the same 'code' style across all easyconfigs): please use one URL per line (and indent with 4 spaces), and I don't see a need for using backup_url (I think that was a trick to avoid very long lines?):

source_urls = [
    'http://origin.releases.qt-project.org/qt4/source/',
    'http://master.qt-project.org/archive/qt/%(major_minor_version)s/%(version)s/',
]

Hi Ken, no problem, good to learn the ropes I'll be doing some bigger
commits soon :o)

Jack Hale

On 26 January 2014 17:33, Kenneth Hoste [email protected] wrote:

In easybuild/easyconfigs/q/Qt/Qt-4.8.4-goalf-1.1.0-no-OFED.eb:

@@ -6,7 +6,8 @@ description = "Qt is a comprehensive cross-platform C++ application framework."

toolchain = {'name': 'goalf', 'version': '1.1.0-no-OFED'}

-source_urls = ['http://origin.releases.qt-project.org/qt4/source/']
+backup_url = 'http://master.qt-project.org/archive/qt/%(major_minor_version)s/%(version)s/'
+source_urls = ['http://origin.releases.qt-project.org/qt4/source/', backup_url]

@jhale https://github.com/jhale: a style remark (we try very hard to
maintain the same 'code' style across all easyconfigs): please use one URL
per line (and indent with 4 spaces), and I don't see a need for using
backup_url (I think that was a trick to avoid very long lines?):

source_urls = [
'http://origin.releases.qt-project.org/qt4/source/',
'http://master.qt-project.org/archive/qt/%(major_minor_version)s/%(version)s/',

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/676/files#r9176382
.