Skip to content

Use -D_GNU_SOURCE for flex-2.6.4-GCCcore-7.3.0 as well#6766

Merged
boegel merged 2 commits intoeasybuilders:developfrom
crubb:flex-2.6.4-GCCcore
Aug 29, 2018
Merged

Use -D_GNU_SOURCE for flex-2.6.4-GCCcore-7.3.0 as well#6766
boegel merged 2 commits intoeasybuilders:developfrom
crubb:flex-2.6.4-GCCcore

Conversation

@crubb
Copy link
Copy Markdown
Contributor

@crubb crubb commented Aug 25, 2018

Now that I built Doxygen, which depends on flex, I found that we need to add -D_GNU_SOURCE to preconfigopts not only for the dummy flex, but also the GCCcore-7.3.0 flex. Otherwise, flex will segfault when building Doxygen.

Please refer to #5792.

Should we add the preconfigopts to the other flex-2.6.4-GCCcore-*.eb as well?

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 28, 2018

@crubb Yes, let's make this consistent in the other flex 2.6.4 easyconfigs please.

@boegel boegel added the bug fix label Aug 28, 2018
@boegel boegel added this to the 3.7.0 milestone Aug 28, 2018
@crubb
Copy link
Copy Markdown
Contributor Author

crubb commented Aug 28, 2018

Done!

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 29, 2018

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node2062.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/fad84b94f8dc2a02b7672d4ff5ece340 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 29, 2018

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node2426.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/f566115733576cf58abfee65e13e1558 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 29, 2018

Going in, thanks @crubb!

@boegel boegel merged commit 756bf23 into easybuilders:develop Aug 29, 2018
@crubb crubb deleted the flex-2.6.4-GCCcore branch January 9, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants