{lib}[foss/2018a,Python/3.6.4] cget v0.1.6#6780
Conversation
|
|
||
| toolchain = {'name': 'foss', 'version': '2018a'} | ||
|
|
||
| exts_defaultclass = 'PythonPackage' |
There was a problem hiding this comment.
@jdemeul Please move this down right above the exts_list = line, and also include this (we want to start migrating to this by default for Python packages):
exts_default_options = {
'download_dep_fail': True,
'use_pip': True,
}This i) checks whether additional Python packages are downloaded & installed automatically (which we don't like, since then we don't control the versions), ii) uses pip rather than the default setup.py install procedure to install the Python packages (which is the recommended way to install Python packages).
So, you'll need to re-test this easyconfig and potentially add other Python packages (in he right order).
|
|
||
| dependencies = [ | ||
| ('Python', '3.6.4'), | ||
| ('CMake', '3.10.2'), |
There was a problem hiding this comment.
@jdemeul Is CMake a runtime dependency here?
Better clarify that with a comment above this line, since that's really uncommon...
| ('click', '6.6', { | ||
| 'source_urls': ['https://pypi.python.org/packages/source/c/click/'], | ||
| 'checksums': [ | ||
| 'cc6a19da8ebff6e7074f731447ef7e112bd23adf3de5c597cf9989f2fd8defe9', # click-6.6.tar.gz |
There was a problem hiding this comment.
@jdemeul No need for the comment, and this can be collapsed to a single line; eb --inject-checksums will do this for you)
| }), | ||
| ] | ||
|
|
||
| exts_default_options = { |
There was a problem hiding this comment.
@jdemeul This usually goes above exts_list (below exts_defaultclass), do you mind moving it for consistency?
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @jdemeul! |
(created using
eb --new-pr)