Skip to content

GTS - Add pkg-config build dependency#6819

Merged
boegel merged 1 commit intoeasybuilders:developfrom
vanzod:20180906134249_new_pr_GTS076
Sep 11, 2018
Merged

GTS - Add pkg-config build dependency#6819
boegel merged 1 commit intoeasybuilders:developfrom
vanzod:20180906134249_new_pr_GTS076

Conversation

@vanzod
Copy link
Copy Markdown
Member

@vanzod vanzod commented Sep 6, 2018

(created using eb --new-pr)

@vanzod vanzod requested a review from boegel September 6, 2018 18:49
@vanzod vanzod added the bug fix label Sep 6, 2018
@vanzod vanzod added this to the 3.7.0 milestone Sep 6, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 6, 2018

@vanzod Any reason you skipped GTS-0.7.6-intel-2014b.eb?

@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Sep 6, 2018

@boegel Actually, three reasons:

  1. I'm lazy
  2. intel-2014b or corresponding minimal toolchains do not have a pkg-config easyconfig
  3. The toolchain is old enough that I deemed the effort of creating a new pkg-config unnecessary (corollary to point 1)

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2018

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in this PR)
node2002.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/da15ec4e04344daf6c4e6a50cdda02f1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2018

@vanzod I agree it's not worth the trouble...

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 11, 2018

Going in, thanks @vanzod!

@boegel boegel merged commit 8aae553 into easybuilders:develop Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants