Skip to content

add wish -> wish8.6 symlink to Tk#6870

Merged
boegel merged 6 commits intoeasybuilders:developfrom
mstud:develop
Sep 20, 2018
Merged

add wish -> wish8.6 symlink to Tk#6870
boegel merged 6 commits intoeasybuilders:developfrom
mstud:develop

Conversation

@mstud
Copy link
Copy Markdown
Contributor

@mstud mstud commented Sep 20, 2018

Tk only installs an executable named "wish8.6", but other software (e.g. FSL) usually looks for just "wish" without the version number. OS packages from e.g. RHEL also install a "wish" executable instead of the versioned one, so with this change, the EasyConfig creates a symlink in the bin dir from "wish" -> "wish8.6".

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstud Please change this consistently in at least all easyconfigs for Tk 8.6.8 (i.e. the most recent version)

Comment thread easybuild/easyconfigs/t/Tk/Tk-8.6.8-GCCcore-6.4.0.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2419.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/168ba9c6930b42c16de3eb471ec7c31e for a full test report.

@mstud
Copy link
Copy Markdown
Contributor Author

mstud commented Sep 20, 2018

@boegel Okay I have removed the superfluous line and also applied the change to the other 8.6.8 easyconfigs.

@boegel boegel added this to the 3.7.0 milestone Sep 20, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node3101.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/19d04d92e55310e3b67d0881ba643dc3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
gligar01.gligar.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e5996ebf1371535f73659e528cb85f2d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 20, 2018

Going in, thanks @mstud!

@boegel boegel merged commit 3bab36d into easybuilders:develop Sep 20, 2018
@mstud mstud deleted the develop branch September 20, 2018 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants