Skip to content

download sources via git for XGBoost 20171120 easyconfig due to use of submodules#6880

Merged
boegel merged 12 commits intoeasybuilders:developfrom
ComputeCanada:sources_from_git_xgboost
Jun 8, 2021
Merged

download sources via git for XGBoost 20171120 easyconfig due to use of submodules#6880
boegel merged 12 commits intoeasybuilders:developfrom
ComputeCanada:sources_from_git_xgboost

Conversation

@mboisson
Copy link
Copy Markdown
Contributor

@mboisson mboisson commented Sep 20, 2018 •
edited by boegel
Loading

This is an example of recipe that uses feature included in easybuilders/easybuild-framework#2555

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 28, 2019

@mboisson Add checksums please

@mboisson
Copy link
Copy Markdown
Contributor Author

mboisson commented Aug 28, 2019

Mmmm, checksums are pointless when cloning from a git repository, they will depend on the tar tool and platform on which the cloned repo is tarball'd. The commit number should be enough ?

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 28, 2019

Ah, didn't notice the recursive...

Kicking Travis due to changes in EasyBuild testing

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 28, 2019

Travis kicked

@akesandgren akesandgren reopened this Aug 28, 2019
@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 29, 2019

Some local variable name changes needed.

akesandgren
akesandgren previously requested changes Aug 29, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/x/XGBoost/XGBoost-20171120-intel-2017b-Java-1.8.0_152.eb
@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 29, 2019

Also there is a conflict of some kind to resolve.

@mboisson
Copy link
Copy Markdown
Contributor Author

mboisson commented Aug 29, 2019

Mmm, there should be no more conflict. Closing and reopening

@mboisson mboisson closed this Aug 29, 2019
@mboisson mboisson reopened this Aug 29, 2019
@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 30, 2019

Travis still thinks there is a conflict, can't see what it is...

@lexming lexming self-assigned this Oct 18, 2020
@easybuilders easybuilders deleted a comment from boegelbot Dec 11, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 11, 2020

@mboisson Please merge ComputeCanada#16, which should make this PR (finally) too to go...

@boegel boegel added this to the 4.x milestone Dec 11, 2020
@boegel boegel changed the title modified XGBoost recipe to use the new feature to download sources from git download sources via git for XGBoost easyconfig due to use of submodules Dec 11, 2020
@lexming lexming removed their assignment Dec 11, 2020
@mboisson
Merge pull request #16 from boegel/sources_from_git_xgboost
af90306 
add None as checksum in XGBoost easyconfig using git_config in sources (+ fix merge conflict)
@easybuilders easybuilders deleted a comment from boegelbot Dec 11, 2020
@boegel boegel mentioned this pull request Dec 11, 2020
Merged
@bartoldeman
Merge pull request #17 from boegel/sources_from_git_xgboost
7b69a1f 
stick to specific Java 1.8.x version + replace tabs by spaces in XGBoost 20171120 easyconfig
@easybuilders easybuilders deleted a comment from boegelbot Dec 11, 2020
@boegel boegel mentioned this pull request Dec 11, 2020
Merged
@bartoldeman
Merge pull request #18 from boegel/sources_from_git_xgboost
4eece1b 
undo unintended rename of GRNBoost easyconfig
@boegel boegel changed the title download sources via git for XGBoost easyconfig due to use of submodules download sources via git for XGBoost 20171120 easyconfig due to use of submodules Dec 11, 2020
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 11, 2020

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
node3129.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/9b505fb0043b3c2fd41c6abb26fb6ad6 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 11, 2020

Hmm, tests seem to be failing due to java.net.ConnectException: Connection refused (Connection refused)

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 11, 2020

Hmm, tests seem to be failing due to java.net.ConnectException: Connection refused (Connection refused)

Looks like a known issue with the tests failing in some network configurations, see dmlc/xgboost#4484...

My vote would go to disabling that test.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2021

Looks like the failing tests were a fluke, they're passing now (see upcoming test report), so this should be good to go...

@boegel boegel mentioned this pull request Jun 8, 2021
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2021

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node2617.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/d3597c7ba7331a10ab32e1e5af1db541 for a full test report.

@boegel boegel dismissed akesandgren’s stale review June 8, 2021 19:07

all good now

boegel
boegel approved these changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2021

Going in, thanks @mboisson!

@boegel boegel merged commit e4bbd49 into easybuilders:develop Jun 8, 2021
@boegel boegel modified the milestones: 4.x, next release (4.4.1) Jun 8, 2021
@mboisson mboisson deleted the sources_from_git_xgboost branch June 8, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren left review comments

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@mboisson @akesandgren @boegel @lexming @bartoldeman