{bio}[goolf/1.4.10] CONTRAlign 2.01 (REVIEW)#690
{bio}[goolf/1.4.10] CONTRAlign 2.01 (REVIEW)#690boegel merged 15 commits intoeasybuilders:developfrom
Conversation
|
SUCCESS |
There was a problem hiding this comment.
space after comma perhaps?
and, ''' triple quote operator above, I think would be nicer instead of """... stylistic, no worries
There was a problem hiding this comment.
@pescobar: plz follow up? this is not difficult to tune
|
looks good - and PR worked, too! |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @fgeorgatos |
|
Test report by @fgeorgatos |
|
minor changes needed here, put this in REVIEW plz! |
|
@pescobar: will send you a PR to fix these remarks |
sync with develop & fix style remarks
|
Jenkins: ok to test |
|
Jenkins: test this please |
1 similar comment
|
Jenkins: test this please |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5805/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@pescobar ping on remarks? |
…ar/easybuild-easyconfigs
…s into contralign
|
Test report by @pescobar |
|
@pescobar filename should be |
| @@ -0,0 +1,21 @@ | |||
| --- contralign.orig/src/Makefile 2008-08-15 03:06:30.000000000 +0200 | |||
There was a problem hiding this comment.
@pescobar please add a line of comment explaining the patch, and add yourself as an author?
|
Test report by @boegel |
|
@pescobar please move the easyconfig files down into the right directory... |
|
Test report by @boegel |
|
lgtm |
|
Going in, thanks @pescobar! |
added the two possible "flavours" of this app and the required patch for gcc-4.7.2