{bio}[foss/2018b] seq2HLA v20180802#6969
Conversation
| easyblock = 'Tarball' | ||
|
|
||
| name = 'seq2HLA' | ||
| version = '20180802' |
There was a problem hiding this comment.
@smoors I think it makes sense to go with 2.3 here, since that's what this (fairly old) commit clearly points to.
There was a problem hiding this comment.
@boegel fine by me, I'm just a little worried that the code for this version might change because it is not a real release.
| ] | ||
|
|
||
| postinstallcmds = [ | ||
| 'sed -i -e "1i #!/usr/bin/env python" %(installdir)s/seq2HLA.py', |
There was a problem hiding this comment.
@smoors You should also enable execution permissions (to avoid that users have to use python $EBROOTSEQ2HLA/seq2HLA.py and can just run seq2HLA.py)?
There was a problem hiding this comment.
it already has execute permissions, so this is not necessary.
I guess your plan is to go further with my PR? I will add your sanity check command then.
we can also keep the both PRs, since yours is with a different toolchain.
There was a problem hiding this comment.
#6965 already got merged, but it indeed makes sense to go forward with both because of the different toolchains.
Do you mind syncing this PR with develop, and adding the missing R dependency in the seq2HLA easyconfig that got merged in #6965?
I guess you can drop the post-install command I added for the permissions too since they're fine already.
There was a problem hiding this comment.
sure, but shouldn't you create a Python2 version of R with intel/2018a first?
There was a problem hiding this comment.
@smoors After thinking about this a bit, I'm not sure it's worth that effort...
Let's go forward in this PR with including R as dependency for seq2HLA, but not for older toolchains. As far as I understand, R is very optional anyway as dependency here?
There was a problem hiding this comment.
I don't think R is optional actually. but that should not hold this PR back, right? :)
|
@smoors |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @smoors! |
(created using
eb --new-pr)