{bio}[intel/2018a] GenomeTester4 v4.0#6970
Conversation
| files_to_copy = [ | ||
| (['bin/glistcompare', 'bin/glistmaker', 'bin/glistquery', | ||
| 'bin/gmer_caller', 'bin/gmer_counter'], "bin"), | ||
| ] |
There was a problem hiding this comment.
@verdurin You can just make this:
files_to_copy = ['bin']To make it copy the whole bin directory, and then check for specific binaries in the sanity check (which you're already doing); that will avoid having to update this in case additional binaries are added in future versions...
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
| toolchain = {'name': 'intel', 'version': '2018a'} | ||
|
|
||
| source_urls = ['https://github.com/bioinfo-ut/GenomeTester4/archive/'] | ||
| sources = ['Version_4_0.tar.gz'] |
There was a problem hiding this comment.
@verdurin Hmm, I overlooked this earlier... How does this relate to the 0.4 version exactly? Should we use %(version_minor)s here?
There was a problem hiding this comment.
@boegel yes, it appears I made that up in attempt to reconstruct a release history that doesn't really exist.
If you look at https://github.com/bioinfo-ut/GenomeTester4/releases it's described as test.
Calling it version 4 feels wrong, nevertheless.
There was a problem hiding this comment.
I'd say 4.0 is the right version, and then you can use:
sources = ['Version_%(version_major)s_%(version_minor)s.tar.gz']Remove file with incorrect versioning scheme
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @verdurin! |
(created using
eb --new-pr)