{math} [intel/2018b] gap/4.9.3 by wpoely86 · Pull Request #7040 · easybuilders/easybuild-easyconfigs

wpoely86 · 2018-10-17T10:46:36Z

No description provided.

wpoely86 · 2018-10-18T11:07:20Z

Test report by @wpoely86
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/56cc4543c0ef1652abc225e4b94fb4d6 for a full test report.

boegel · 2018-10-19T14:39:45Z

+
+# This tries to install all of the GAP packages. If one fails because
+# of missing dependencies, it's skipped automatically
+preinstallopts = 'cd pkg && ../bin/BuildPackages.sh && cd .. #'


@wpoely86 Please use skipsteps = ['install'] to skip the installation steps, and do the above via buildopts?

this should be run after the build_step is done

Well, yes, you can do that via

buildopts = " && cd pkg && ../bin/BuildPackages.sh"

(the cd .. at the end is pointless)

It's the trailing # that I don't like here, this falls in the "hacking" category for me. ;-)

boegel · 2018-10-19T14:40:25Z

+postinstallcmds = ["cd bin && ln -s gap.sh gap && cd -"]
+
+sanity_check_paths = {
+    'files': ['bin/gap.sh', 'gap', 'gac'],


this should be bin/gap?

no, the real file is gap.sh. With the postinstallcmds I add a symlink gap -> gap.sh

If you check for bin/gap, you make sure the symlink is effectively there, and that it points to an existing file. So why not check both?

boegel · 2018-10-19T14:40:42Z

+# of missing dependencies, it's skipped automatically
+preinstallopts = 'cd pkg && ../bin/BuildPackages.sh && cd .. #'
+
+postinstallcmds = ["cd bin && ln -s gap.sh gap && cd -"]


You can drop the cd -, since this command is run in a subshell

boegel · 2018-10-19T14:40:56Z

+
+sanity_check_paths = {
+    'files': ['bin/gap.sh', 'gap', 'gac'],
+    'dirs': ['pkg']


No more specific checks for particular packages?

it's a very long list and I don't know if any are more important then others.

And this comes directly from the tarball. It's not because it's there that it will work

OK, fine then :)

boegel · 2018-10-19T14:42:07Z

+toolchain = {'name': 'intel', 'version': '2018b'}
+
+source_urls = ['http://cgm.cs.mcgill.ca/~avis/C/lrslib/archive/']
+sources = ['%%(name)s-0%s.tar.gz' % version.replace('.', '')]


Please use %(name)s-0%(version_major)s%(version_minor)s.tar.gz

boegel · 2018-10-19T14:43:02Z

+-		g++ -Wall -Wno-write-strings -Wno-sign-compare -Wno-unused-variable -I${BOOSTINC}  -L${BOOSTLIB} -Wl,-rpath=${BOOSTLIB} -O3 -DPLRS -o plrsmp plrs.cpp lrslib.c lrsmp.c  -lboost_thread -lboost_system
+		$(CXX) $(CXXFLAGS) -DGMP  -Wall -Wno-write-strings -Wno-sign-compare -I${BOOSTINC}  -O3 -DPLRS -DGMP -o plrs plrs.cpp lrslib.c lrsgmp.c -L${BOOSTLIB} -lboost_thread -lboost_system -lgmp
+		$(CXX) $(CXXFLAGS)  -Wall -Wno-write-strings -Wno-sign-compare -Wno-unused-variable -I${BOOSTINC}  -L${BOOSTLIB} -O3 -DPLRS -DLRSLONG -o plrs1 plrs.cpp lrslib.c lrslong.c -lboost_thread -lboost_system
+		$(CXX) $(CXXFLAGS) -Wall -Wno-write-strings -Wno-sign-compare -Wno-unused-variable -I${BOOSTINC}  -L${BOOSTLIB} -O3 -DPLRS -o plrsmp plrs.cpp lrslib.c lrsmp.c  -lboost_thread -lboost_system


@wpoely86 Remove the hardcoded -O3? Same below...

boegel · 2018-10-19T14:43:29Z

+
+ fourier:	fourier.c lrslib.h lrslib.c lrsgmp.h lrsgmp.c
+-	$(CC) $(CFLAGS) -O3 -DTIMES -DSIGNALS  -DGMP -I${INCLUDEDIR} fourier.c lrslib.c lrsgmp.c -L${LIBDIR}  -lgmp -o fourier
+	$(CC) $(CFLAGS) -O3 -DTIMES -DSIGNALS  -DGMP -I${INCLUDEDIR} fourier.c lrslib.c lrsgmp.c -L${LIBDIR} $(LDFLAGS) -lgmp -o fourier


@wpoely86 More hardcoded -O3 to remove?

boegel · 2018-10-19T14:44:14Z

+dependencies = [('GMP', '6.1.2')]
+
+sanity_check_paths = {
+    'files': ['bin/normaliz', 'bin/Qnormaliz', 'lib/libnormaliz.so', 'lib/libQnormaliz.so'],


@wpoely86 Please use SHLIB_EXT rather than hardcoding .so

sanity_check_paths = { 'files': ['bin/normaliz', 'bin/Qnormaliz', 'lib/libnormaliz.%s' % SHLIB_EXT, 'lib/libQnormaliz.%s' % SHLIB_EXT], 'dirs': ['include/libnormaliz'] }

wpoely86 · 2018-10-24T08:14:53Z

Test report by @wpoely86
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/e5a1b7895b1f6ea3b594a947a5d90bb5 for a full test report.

wpoely86 · 2018-10-25T07:16:28Z

Test report by @wpoely86
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/bf0d741343a36d79ff07e7ccb82f28fa for a full test report.

wpoely86 · 2018-10-25T08:23:47Z

Test report by @wpoely86
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/5958d9f138335b851e4ba723fe20ff1d for a full test report.

wpoely86 · 2018-10-25T08:39:31Z

Test report by @wpoely86
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/0bad8082d0cf6e6cf75d783791508850 for a full test report.

boegel · 2018-10-25T19:42:49Z

@wpoely86 You should skip the install step?

wpoely86 · 2018-10-26T07:52:01Z

Test report by @wpoely86
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/8bbd6820b1d1a42860c2011fb09131c8 for a full test report.

wpoely86 · 2018-10-26T08:55:20Z

Test report by @wpoely86
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/86d97bf4b89960bfebf1a5c42cf05be0 for a full test report.

boegel · 2018-10-27T17:02:03Z

Test report by @boegel
FAILED
Build succeeded for 3 out of 5 (5 easyconfigs in this PR)
node3111.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/f5a925bb232890b0cbc66b4c52dedb82 for a full test report.

boegel · 2018-10-27T17:15:22Z

Test report by @boegel
FAILED
Build succeeded for 4 out of 6 (5 easyconfigs in this PR)
node2699.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5cbb9f0263ba59a308db96b5ecd3f451 for a full test report.

boegel · 2018-10-27T17:16:57Z

Test report by @boegel
FAILED
Build succeeded for 3 out of 5 (5 easyconfigs in this PR)
node2060.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9d3cf857edc1f574e0c1550fa0f5d0c4 for a full test report.

boegel · 2018-10-28T06:43:43Z

@wpoely86 Missing dependency on Boost for Normaliz?

./libnormaliz/matrix.h(41): catastrophic error: cannot open source file "boost/dynamic_bitset.hpp"
#include <boost/dynamic_bitset.hpp>

wpoely86 · 2018-10-29T09:04:47Z

Test report by @wpoely86
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
nic420 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/6b624f8319dea804218d9fbe167556e1 for a full test report.

wpoely86 · 2018-10-29T10:07:22Z

@boegel can you retry?

boegel · 2018-10-31T16:06:53Z

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2464.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/e9dc8aeabda35c46d9adbe0f728b3dcc for a full test report.

boegel · 2018-10-31T16:55:57Z

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2095.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/53b08a31e121793156830d70ffc0eaff for a full test report.

boegel · 2018-10-31T20:05:44Z

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node3152.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/590cac653de029168e24039cb9613103 for a full test report.

boegel · 2018-11-01T08:15:46Z

Going in, thanks @wpoely86!

wpoely86 added 4 commits October 17, 2018 12:42

Add 4ti2

e5b19e8

Add Normaliz

4f2825d

Add lrslib

8fe5cfa

Add gap

9e99a31

wpoely86 requested a review from boegel October 17, 2018 10:46

wpoely86 changed the base branch from master to develop October 17, 2018 10:46

wpoely86 added 4 commits October 17, 2018 13:24

Add missing boost dep

0fcf287

Add Boost/1.67 for intel/2018b

a892c2f

Switch to Boost/1.67.0

b783b38

Style fix

00eff08

easybuilders deleted a comment from boegelbot Oct 18, 2018

boegel added new update labels Oct 19, 2018

boegel requested changes Oct 19, 2018

View reviewed changes

Fix remarks

5e2be09

Fix remarks

fa3e141

Fix bug

f3d4c42

Skip install step

ca37e97

boegel previously approved these changes Oct 27, 2018

View reviewed changes

Add Boost as dep for Normaliz

d446617

wpoely86 dismissed boegel’s stale review via d446617 October 29, 2018 08:51

boegel approved these changes Oct 31, 2018

View reviewed changes

boegel added this to the 3.8.0 milestone Nov 1, 2018

boegel merged commit cc5c4ed into easybuilders:develop Nov 1, 2018

wpoely86 deleted the gap branch November 2, 2018 12:40

Conversation

wpoely86 commented Oct 17, 2018

Uh oh!

wpoely86 commented Oct 18, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpoely86 commented Oct 24, 2018

Uh oh!

wpoely86 commented Oct 25, 2018

Uh oh!

wpoely86 commented Oct 25, 2018

Uh oh!

wpoely86 commented Oct 25, 2018

Uh oh!

boegel commented Oct 25, 2018

Uh oh!

wpoely86 commented Oct 26, 2018

Uh oh!

wpoely86 commented Oct 26, 2018

Uh oh!

boegel commented Oct 27, 2018

Uh oh!

boegel commented Oct 27, 2018

Uh oh!

boegel commented Oct 27, 2018

Uh oh!

boegel commented Oct 28, 2018

Uh oh!

wpoely86 commented Oct 29, 2018

Uh oh!

wpoely86 commented Oct 29, 2018

Uh oh!

boegel commented Oct 31, 2018

Uh oh!

boegel commented Oct 31, 2018

Uh oh!

boegel commented Oct 31, 2018

Uh oh!

boegel commented Nov 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants