Skip to content

{math}[foss/2018b] XMDS2 2.2.3 (REVIEW)#7121

Merged
boegel merged 5 commits intoeasybuilders:developfrom
hajgato:xmds2
Nov 6, 2018
Merged

{math}[foss/2018b] XMDS2 2.2.3 (REVIEW)#7121
boegel merged 5 commits intoeasybuilders:developfrom
hajgato:xmds2

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Nov 5, 2018

No description provided.

@hajgato hajgato changed the title {math}[foss/2018b] XMDS2 2.2.3 (REVIEW) {math}[foss/2018b] XMDS2 2.2.3 (WIP) Nov 5, 2018
@hajgato hajgato changed the title {math}[foss/2018b] XMDS2 2.2.3 (WIP) {math}[foss/2018b] XMDS2 2.2.3 (REVIEW) Nov 5, 2018
@@ -0,0 +1,64 @@
easyblock = 'Bundle'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato Do you mind changing this to the new PythonBundle, which will be included in EasyBuild v3.8.0 (cfr. easybuilders/easybuild-easyblocks#1553)?


toolchain = {'name': 'foss', 'version': '2018b'}


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato Style nitpicking: please remove duplicate empty line

exts_default_options = {
'download_dep_fail': True,
'use_pip': True,
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole block can be replaced with just use_pip = True if the PythonBundle easyblock is used

'dirs': ['lib/python%(pyshortver)s/site-packages'],
}

modextrapaths = {'PYTHONPATH': ['lib/python%(pyshortver)s/site-packages']}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line can be removed if the PythonBundle easyblock is used

@boegel boegel added this to the 3.8.0 milestone Nov 6, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 6, 2018

Test report by @boegel
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in this PR)
node2060.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/3343621de370f7c279a7c1292156f4cd for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 6, 2018

@hajgato (still) a checksum issue?

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 6, 2018

@boegel its sourceforge-download issue. For some reason, only manual download works.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 6, 2018

@boegel changed to PythonBundle

('xmds', version, {
'modulename': 'xpdeint',
'patches': ['XMDS2-2.2.3_HDF5_OpenBLAS.patch'],
'source_urls': ['http://download.sourceforge.net/projects/xmds'],
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato This should probably be https://download.sourceforge.net/xmds (no /projects/, and make it https).

$ eb --avail-easyconfig-templates | grep FORGE
    SOURCEFORGE_SOURCE: sourceforge.net source url (https://download.sourceforge.net/%(namelower)s)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel fixed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 6, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2417.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/3f2e441c4e58ea10e110377276f224eb for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 6, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3100.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/54bb1d12cd56b609d7818eef76be99e7 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 6, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2060.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/48510be65c41564bd380d963498f25f4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 6, 2018

Going in, thanks @hajgato!

@boegel boegel merged commit 8c51df0 into easybuilders:develop Nov 6, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 6, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2104.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/92bb645a27868981e6fd5e1c475e4de9 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants