Skip to content

add gllvm extension (+ deps) to R 3.5.1 easyconfigs#7123

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:R351_gllvm
Nov 6, 2018
Merged

add gllvm extension (+ deps) to R 3.5.1 easyconfigs#7123
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:R351_gllvm

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 5, 2018

No description provided.

@boegel boegel added this to the 3.8.0 milestone Nov 5, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2602.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/d991be2814a684c1752a1fb70d52b017 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2090.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/1f15f7734e31234ea30947268dab05a3 for a full test report.

Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok to me, lack of consistency in order of extensions between the two ecs feels like a maintenance burden (but then so does having 2 easyconfigs that are identical apart from a Python dep)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 6, 2018

@ocaisa The order of extensions is not different, there were a couple of extensions missing in one of these (the ones that were added in #6901), I fixed that inconsistency...

diff -u easybuild/easyconfigs/r/R/R-3.5.1-foss-2018b-Python-2.7.15.eb easybuild/easyconfigs/r/R/R-3.5.1-foss-2018b.eb
--- easybuild/easyconfigs/r/R/R-3.5.1-foss-2018b-Python-2.7.15.eb	2018-11-06 16:39:23.000000000 +0100
+++ easybuild/easyconfigs/r/R/R-3.5.1-foss-2018b.eb	2018-11-06 16:39:23.000000000 +0100
@@ -1,6 +1,5 @@
 name = 'R'
 version = '3.5.1'
-versionsuffix = '-Python-%(pyver)s'

 homepage = 'http://www.r-project.org/'
 description = """R is a free software environment for statistical computing and graphics."""
@@ -15,7 +14,6 @@
     ('pkg-config', '0.29.2'),
 ]
 dependencies = [
-    ('Python', '2.7.15'),
     ('X11', '20180604'),
     ('Mesa', '18.1.1'),
     ('libGLU', '9.0.0'),
@@ -34,7 +32,7 @@
     ('Tk', '8.6.8'),  # for tcltk
     ('cURL', '7.60.0'),  # for RCurl
     ('libxml2', '2.9.8'),  # for XML
-    ('GDAL', '2.2.3', versionsuffix),  # for rgdal
+    ('GDAL', '2.2.3', '-Python-3.6.6'),  # for rgdal
     ('PROJ', '5.0.0'),  # for rgdal
     ('GMP', '6.1.2'),  # for igraph
     ('NLopt', '2.4.2'),  # for nloptr

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Nov 6, 2018

Ok, thanks for clarifying, I see where the need for the python2 one comes from now too.

@ocaisa ocaisa merged commit bafe4d5 into easybuilders:develop Nov 6, 2018
@boegel boegel deleted the R351_gllvm branch November 6, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants