Skip to content

Install Tk private headers#7155

Merged
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:tk-private-headers
Nov 14, 2018
Merged

Install Tk private headers#7155
boegel merged 2 commits intoeasybuilders:developfrom
hajgato:tk-private-headers

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Nov 13, 2018

boegel
boegel requested changes Nov 13, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/t/Tk/Tk-8.6.8-GCCcore-6.4.0.eb Outdated

postinstallcmds = ["ln -s wish%(version_major_minor)s %(installdir)s/bin/wish"]
postinstallcmds = [
"make install-private-headers",
Copy link
Copy Markdown
Member

@boegel boegel Nov 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato Wouldn't it be better to do this via installopts?

installopts = "&& make install-private-headers"

Also, we should enhance sanity_check_paths to check for at least one of these header files?

Copy link
Copy Markdown
Collaborator Author

@hajgato hajgato Nov 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Done.

@boegel boegel added this to the 3.8.0 milestone Nov 13, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2606.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/44517ac38fb83654a5d46cfc55b74ced for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2040.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/801c8d775544f584629d694719b08515 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2018

Test report by @boegel
SUCCESS
Build succeeded for 8 out of 8 (4 easyconfigs in this PR)
node3124.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/6cd8d529e712fe0ccd9426727da78b39 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2018

Going in, thanks @hajgato!

@boegel boegel merged commit 197789f into easybuilders:develop Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@hajgato @boegel