Skip to content

{numlib}[GCC/7.3.0-2.30] BLIS v1.2-amd, libFLAME v1.0-amd#7163

Merged
boegel merged 5 commits intoeasybuilders:developfrom
migueldiascosta:20181115063516_new_pr_AMD-BLIS12
May 8, 2019
Merged

{numlib}[GCC/7.3.0-2.30] BLIS v1.2-amd, libFLAME v1.0-amd#7163
boegel merged 5 commits intoeasybuilders:developfrom
migueldiascosta:20181115063516_new_pr_AMD-BLIS12

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Nov 15, 2018

(created using eb --new-pr)

(adapted from #6614)

@migueldiascosta migueldiascosta changed the title {numlib}[GCC/7.3.0-2.30] AMD-BLIS v1.2 {numlib}[GCC/7.3.0-2.30] AMD-BLIS v1.2, AMD-libFLAME v1.0 Nov 15, 2018
@migueldiascosta
Copy link
Copy Markdown
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
ip-172-31-8-244.us-west-2.compute.internal - Linux RHEL 7.6, AMD EPYC 7571, Python 2.7.5
See https://gist.github.com/a4196f02488be8466df95e07ed555fc9 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

I wonder what the benefit of this blis is over the upstream blis? As far as I know all AMD changes were merged back but that was >3 months ago. Would be good to see a diff.
(just trying to keep complexity down if this also is going to end up in toolchains).

@migueldiascosta
Copy link
Copy Markdown
Member Author

@bartoldeman more than the current diff, it would be good to know if they will always merge back

Currently the diff is minor, "Improved single thread Triangular Solve Matrix (TRSM) performance for small matrices on AMD EPYC Family processors", flame/blis@master...amd:master

I agree that we should only consider an amd toolchain if there is stronger reason for it, but for now the easyconfigs don't hurt (?)

Also, I'm happy with leaving this (and #7164 and #7165) as WIP until more is known

Comment thread easybuild/easyconfigs/a/AMD-BLIS/AMD-BLIS-1.2-GCC-7.3.0-2.30.eb
@verdurin
Copy link
Copy Markdown
Member

@migueldiascosta ping on the versionsuffix suggested by @boegel ?

@migueldiascosta migueldiascosta changed the title {numlib}[GCC/7.3.0-2.30] AMD-BLIS v1.2, AMD-libFLAME v1.0 {numlib}[GCC/7.3.0-2.30] BLIS v1.2-amd, libFLAME v1.0-amd Nov 29, 2018
@boegel boegel added this to the 3.x milestone May 8, 2019
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3118.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/c310f3b9ae241e146e299570d7550101 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2039.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/1229511ab29a220801f676f9cce6ae36 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2406.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/b56316ba2eeee8055e279569dd6d66e3 for a full test report.

@boegel boegel modified the milestones: 3.x, next release (3.9.1) May 8, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Going in, thanks @migueldiascosta!

@boegel boegel merged commit eeda7b1 into easybuilders:develop May 8, 2019
@migueldiascosta migueldiascosta deleted the 20181115063516_new_pr_AMD-BLIS12 branch October 2, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants