Skip to content

{base}[foss/2017b] Gerris v20131206, GTS v20121130#7211

Merged
verdurin merged 3 commits intoeasybuilders:developfrom
dquigley533:20181128141403_new_pr_Gerris20131206
Dec 3, 2018
Merged

{base}[foss/2017b] Gerris v20131206, GTS v20121130#7211
verdurin merged 3 commits intoeasybuilders:developfrom
dquigley533:20181128141403_new_pr_Gerris20131206

Conversation

@dquigley533
Copy link
Copy Markdown
Contributor

@dquigley533 dquigley533 commented Nov 28, 2018

(created using eb --new-pr)

@dquigley533
Copy link
Copy Markdown
Contributor Author

dquigley533 commented Nov 28, 2018

Test report by @dquigley-warwick
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
cedar.theory.warwick.ac.uk - Linux centos linux 7.5.1804, Intel(R) Core(TM)2 Quad CPU Q8400 @ 2.66GHz, Python 2.7.5
See https://gist.github.com/65379e4384e54572d96819d6433077cc for a full test report.

@verdurin verdurin added this to the 3.8.0 milestone Nov 28, 2018
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 28, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 8 out of 8 (2 easyconfigs in this PR)
rescomp2 - Linux centos linux 7.3.1611, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, Python 2.7.11
See https://gist.github.com/ba734b84aa2b8a1d38964296b393e93b for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 28, 2018

@dquigley-warwick thanks for the PR.

Could you explain why you have removed the GLib dependency?

Thanks,
Adam

@dquigley533
Copy link
Copy Markdown
Contributor Author

dquigley533 commented Nov 28, 2018

@verdurin - that may not have been entirely deliberate. Presumably including that dependency would allow building on older systems? I've only tested on CentOS 7.3 as above.

David

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 28, 2018

@dquigley-warwick - the concern would be that when you built it locally, it picked up a system package that might not be installed by everyone.

@dquigley533
Copy link
Copy Markdown
Contributor Author

dquigley533 commented Nov 29, 2018

Test report by @dquigley-warwick
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
cedar.theory.warwick.ac.uk - Linux centos linux 7.5.1804, Intel(R) Core(TM)2 Quad CPU Q8400 @ 2.66GHz, Python 2.7.5
See https://gist.github.com/16dab3ae75a9c55d412afc8741eda082 for a full test report.

verdurin
verdurin requested changes Dec 2, 2018
View reviewed changes
Comment thread easybuild/easyconfigs/g/GTS/GTS-20121130-foss-2017b.eb
sanity_check_paths = {
'files': ['lib/libgts.%s' % SHLIB_EXT, 'bin/gts2oogl', 'bin/gtscheck'],
'dirs': []
}
Copy link
Copy Markdown
Member

@verdurin verdurin Dec 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dquigley-warwick - one more thing... could you specify the moduleclass?

Comment thread easybuild/easyconfigs/g/Gerris/Gerris-20131206-foss-2017b.eb
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 3, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 0 out of 0 (2 easyconfigs in this PR)
rescomp2 - Linux centos linux 7.3.1611, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, Python 2.7.11
See https://gist.github.com/541129b263f62af7e00fa9628fa511f8 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 3, 2018

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
easybuild.novalocal - Linux centos linux 7.5.1804, Intel Xeon E312xx (Sandy Bridge), Python 2.7.5
See https://gist.github.com/6fd71b1854717bbbebc8a7956ccc74d8 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 3, 2018

Going in, thanks @dquigley-warwick!

@verdurin verdurin merged commit 9841339 into easybuilders:develop Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dquigley533 @verdurin