Skip to content

fix ImageMagick source URLs: use launchpad.net for old versions, switch to GitHub for 7.0.8-* onwards#7301

Merged
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:ImageMagick_source_urls
Dec 13, 2018
Merged

fix ImageMagick source URLs: use launchpad.net for old versions, switch to GitHub for 7.0.8-* onwards#7301
bartoldeman merged 1 commit intoeasybuilders:developfrom
boegel:ImageMagick_source_urls

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 12, 2018

fix for #7274, based on the feedback in https://imagemagick.org/discourse-server/viewtopic.php?f=2&t=35150

There's little point in using https://www.imagemagick.org/download/releases/ as source URL, since source tarballs disappear there when new releases are available.

For versions prior to and including 7.0.8-5, original tarballs can be downloaded from https://launchpad.net/imagemagick/+download.

For newer version, we can use the tags from GitHub, see https://github.com/ImageMagick/ImageMagick/releases/

cc @sassy-crick

@boegel boegel added the bug fix label Dec 12, 2018
@boegel boegel added this to the 3.8.0 milestone Dec 12, 2018
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 13, 2018

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in this PR)
node2001.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/38ca3b6456b3a3160933f8d1b28f527c for a full test report.

@bartoldeman bartoldeman self-requested a review December 13, 2018 13:14
@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Dec 13, 2018

Test report by @bartoldeman
FAILED
Build succeeded for 63 out of 83 (8 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/e0ac8114e787f4a1acb74e0fb3972674 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 13, 2018

@bartoldeman Some dependencies failed due to failing downloads?

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Dec 13, 2018

Test report by @bartoldeman
FAILED
Build succeeded for 5 out of 19 (8 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/259b2489f6c7dbb94f87a1d211ff8176 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Dec 13, 2018

Test report by @bartoldeman
FAILED
Build succeeded for 7 out of 14 (8 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/df09f57a8aad780b9430654fc2f68431 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Dec 13, 2018

Test report by @bartoldeman
FAILED
Build succeeded for 5 out of 7 (8 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/cb1c0282c4ebe6301a522dba3f0e7af7 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Dec 13, 2018

Test report by @bartoldeman
SUCCESS
Build succeeded for 1 out of 1 (8 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/0c99a534baf73693371e6b41b0a788ef for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Dec 13, 2018

there were 3 issues with the dependencies:

  1. nasm downloading did not work. Downloaded manually using wget.
  2. my framework was out of date, for set_parallel
  3. JasPer for foss wants to build documentation, and the local system latex was not up to scratch. JasPer for GCCcore does not do so for some reason. If I do this to JasPer it compiles here:
--- a/easybuild/easyconfigs/j/JasPer/JasPer-2.0.12-foss-2016b.eb
+++ b/easybuild/easyconfigs/j/JasPer/JasPer-2.0.12-foss-2016b.eb
@@ -16,6 +16,8 @@ checksums = ['5b24faf5ed38670d6286e45ab7516b26458d05e7929b435afe569176765f
 
 builddependencies = [('CMake', '3.7.2')]
 
+configopts = '-DJAS_ENABLE_DOC=OFF '
+
 separate_build_dir = True
 
 sanity_check_paths = {

bartoldeman
bartoldeman approved these changes Dec 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman
Copy link
Copy Markdown
Contributor

bartoldeman commented Dec 13, 2018

Going in, thanks @boegel!

@bartoldeman bartoldeman merged commit 2c99d63 into easybuilders:develop Dec 13, 2018
@boegel boegel deleted the ImageMagick_source_urls branch December 14, 2018 10:00
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 14, 2018

@bartoldeman Please open a PR for the JasPer problem you ran into, and maybe also an issue for the NASM download issue

@boegel boegel mentioned this pull request Sep 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoldeman bartoldeman bartoldeman approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @bartoldeman