Skip to content

add fallback source URL for recent pigz versions#7346

Merged
bartoldeman merged 2 commits intoeasybuilders:developfrom
boegel:pigz_fossils
Jan 10, 2019
Merged

add fallback source URL for recent pigz versions#7346
bartoldeman merged 2 commits intoeasybuilders:developfrom
boegel:pigz_fossils

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Dec 24, 2018

fixes #7338

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Dec 24, 2018

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2001.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/9e27354236d5c17f8af6f66c9ebdbb3a for a full test report.

@boegel boegel requested a review from wpoely86 December 27, 2018 13:03
@bartoldeman
Copy link
Copy Markdown
Contributor

Test report by @bartoldeman
FAILED
Build succeeded for 1 out of 4 (4 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/92499330b203f7e2c4df4a1744cd55df for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

Test report by @bartoldeman
FAILED
Build succeeded for 0 out of 4 (4 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/ed80ba67d1c7de3a492fd88f770a0618 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

Test report by @bartoldeman
FAILED
Build succeeded for 1 out of 4 (4 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/79797fab0b375ad118893aa739ae200b for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

Test report by @bartoldeman
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/83ec60f6c35290edbcbcfde759e82f81 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

I ran into this: #5776
If I create lib64->lib symlinks in relevant $EBROOTZLIB then it compiles ok, otherwise it tries to link to /usr/lib64/libz.so

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 5, 2019

@bartoldeman Ugh, thanks for testing and figuring this out, I'm sure that wasn't trivial...

Should this be a blocker for this PR however? It seems like this is a rather obscure problem that doesn't surface often (otherwise more people would be reporting it more frequently), and we should follow up on it via #5776?

@bartoldeman
Copy link
Copy Markdown
Contributor

#2266 ran into the same issue...
at least we now know why it happens: if you search for gzopen64 you will find a few other zlib-related failures.

On CentOS7 the system zlib is new enough so you do not get symbol errrors, but still it uses the system zlib at link time and the EB zlib at runtime.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 8, 2019

@bartoldeman I don't think we can fix this easily in general...

The actual problem here is that pigz doesn't include a proper -L/path/to/zlib compiler option (which gets preference over the paths listed in $LIBRARY_PATH).

So we should look into fixing that?

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 8, 2019

Test report by @verdurin
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
rescomp2 - Linux centos linux 7.3.1611, Intel(R) Xeon(R) Gold 6126 CPU @ 2.60GHz, Python 2.7.5
See https://gist.github.com/62872ba3fb681fe2d2b094eb5b20edf9 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

at least we are aware of the issue now. For pigz I'd simply propose to use
buildopts = 'CC="$CC" CFLAGS="$CFLAGS" LDFLAGS="-L$EBROOTZLIB/lib"'
instead of
buildopts = 'CC="$CC" CFLAGS="$CFLAGS"''
this works for me.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 10, 2019

@bartoldeman Fixed, good to go now?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 10, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2532.golett.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c2680d6f4063dcb77103d6ea127f0ba1 for a full test report.

@bartoldeman
Copy link
Copy Markdown
Contributor

Test report by @bartoldeman
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
lg-1r17-n06 - Linux centos 6.6, Intel(R) Xeon(R) CPU E5-2650 0 @ 2.00GHz, Python 2.6.6
See https://gist.github.com/a8bc893b44597da95b9417e546bb1952 for a full test report.

Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, with the LDFLAGS it works. So I'll merge it now :)

@bartoldeman
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@bartoldeman bartoldeman merged commit f06b990 into easybuilders:develop Jan 10, 2019
@boegel boegel deleted the pigz_fossils branch January 10, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants