Skip to content

disable building of OpenColorIO Python bindings since Python is not included as a dependency#7416

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:OpenColorIO_no_python_bindings
Jan 14, 2019
Merged

disable building of OpenColorIO Python bindings since Python is not included as a dependency#7416
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:OpenColorIO_no_python_bindings

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 13, 2019

(fix for problem reported by @JackPerdue in #7342)

I tested this in an environment where python-devel (and hence Python.h) is not available, which led to the same problem as reported in #7342.

Building of Python bindings is enabled by default, but they shouldn't be unless Python is included as a dependency.

@boegel boegel added the bug fix label Jan 13, 2019
@boegel boegel added this to the 3.8.1 milestone Jan 13, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 13, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3129.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/24cb6c2d9b5dca0774cf99e2fe5d7c39 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 13, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2003.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5fcd0f900e7fa9706db6905c5f677d3a for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 13, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2594.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/4619ded8e93c3be64635f9ec44720180 for a full test report.

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit a68b79f into easybuilders:develop Jan 14, 2019
@boegel boegel deleted the OpenColorIO_no_python_bindings branch January 14, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants