Skip to content

add libunwind dependency to recent Mesa easyconfig when building with foss/GCC#7629

Merged
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20190215151732_new_pr_Mesa1811
Feb 19, 2019
Merged

add libunwind dependency to recent Mesa easyconfig when building with foss/GCC#7629
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20190215151732_new_pr_Mesa1811

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Feb 15, 2019

(created using eb --new-pr)

Check output from
objdump -x .../MPI/GCC/7.3.0-2.30/OpenMPI/3.1.1/Mesa/18.1.1/lib/libGL.so.1 | grep NEEDED
and you should see libunwind there.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Feb 15, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
cermis - Linux debian 9.7, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/b993ed9b7acdd10b8cc31d1b60a889b5 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor Author

@vanzod did your Mesa libGL.so have the same info?

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Feb 15, 2019

@akesandgren Yes, here it is

davide@cermis:~$ objdump -x /opt/easybuild/software/MPI/GCC/7.3.0-2.30/OpenMPI/3.1.1/Mesa/18.1.1/lib/libGL.so.1 | grep libunwind
  NEEDED               libunwind.so.8

@akesandgren
Copy link
Copy Markdown
Contributor Author

Ok, wasn't 100% sure it wasn't just me...

@vanzod vanzod added this to the next release (3.8.2) milestone Feb 15, 2019
@akesandgren
Copy link
Copy Markdown
Contributor Author

Lets wait for a bit of kenneth approval for this one.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2019

libunwind is not listed for me... What did I win? :)

$ objdump -x $EBROOTMESA/lib/libGL.so.1 | grep NEEDED
  NEEDED               libz.so.1
  NEEDED               libglapi.so.0
  NEEDED               libXext.so.6
  NEEDED               libX11.so.6
  NEEDED               libxcb.so.1
  NEEDED               libXau.so.6
  NEEDED               libXdmcp.so.6
  NEEDED               libdl.so.2
  NEEDED               libLLVMX86Disassembler.so.6
  NEEDED               libLLVMX86AsmParser.so.6
  NEEDED               libLLVMX86CodeGen.so.6
  NEEDED               libLLVMGlobalISel.so.6
  NEEDED               libLLVMSelectionDAG.so.6
  NEEDED               libLLVMAsmPrinter.so.6
  NEEDED               libLLVMDebugInfoCodeView.so.6
  NEEDED               libLLVMDebugInfoMSF.so.6
  NEEDED               libLLVMCodeGen.so.6
  NEEDED               libLLVMScalarOpts.so.6
  NEEDED               libLLVMInstCombine.so.6
  NEEDED               libLLVMTransformUtils.so.6
  NEEDED               libLLVMX86Desc.so.6
  NEEDED               libLLVMMCDisassembler.so.6
  NEEDED               libLLVMX86Info.so.6
  NEEDED               libLLVMX86AsmPrinter.so.6
  NEEDED               libLLVMX86Utils.so.6
  NEEDED               libLLVMMCJIT.so.6
  NEEDED               libLLVMExecutionEngine.so.6
  NEEDED               libLLVMTarget.so.6
  NEEDED               libLLVMRuntimeDyld.so.6
  NEEDED               libLLVMBitWriter.so.6
  NEEDED               libLLVMAnalysis.so.6
  NEEDED               libLLVMProfileData.so.6
  NEEDED               libLLVMObject.so.6
  NEEDED               libLLVMMCParser.so.6
  NEEDED               libLLVMMC.so.6
  NEEDED               libLLVMBitReader.so.6
  NEEDED               libLLVMCore.so.6
  NEEDED               libLLVMBinaryFormat.so.6
  NEEDED               libLLVMSupport.so.6
  NEEDED               libLLVMDemangle.so.6
  NEEDED               libpthread.so.0
  NEEDED               libstdc++.so.6
  NEEDED               libm.so.6
  NEEDED               libc.so.6
  NEEDED               ld-linux-x86-64.so.2
  NEEDED               libgcc_s.so.1
$
$ objdump -x $EBROOTMESA/lib/libGL.so.1 | grep NEEDED | grep libunwind
$

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Feb 15, 2019

Was that an GCC or intel build of Mesa?
Or was it Mesa 17?

My Mesa 17.3.6 with foss/2018a does not show libunwind.

Nor does Maximes nix build of Mesa 17

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 15, 2019

@akesandgren That was for Mesa-18.1.1-foss-2018b.eb

@akesandgren
Copy link
Copy Markdown
Contributor Author

Ok, so for some reason only Debian/Ubuntu sees that.
Then I'll have to check again to see if there is something else that makes this happen.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Feb 15, 2019

@boegel One thing, did you have the OS distro libunwind devel package installed when Mesa was built?
I obviously have it. @vanzod How about you? (must have since it was picked up...)

@akesandgren
Copy link
Copy Markdown
Contributor Author

Checking the configure output from Mesa 18 it clearly searches for unwind, Mesa 17 doesn't.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2019

@akesandgren No libunwind-* on our system, so it wasn't there when Mesa was being built.

@boegel boegel changed the title Mesa depends on libunwind when building with GCC. add libunwind dependency to recent Mesa easyconfig when building with foss/GCC Feb 19, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2431.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ed2c87946de7779a5f9b94ce4a2fc4cc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2016.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/7b25b1a820540b5184555078f42189d4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3118.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/e4fa58fb8414792a79263e336b36ed70 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 19, 2019

Going in, thanks @akesandgren!

@boegel boegel merged commit 6cba6e8 into easybuilders:develop Feb 19, 2019
@akesandgren akesandgren deleted the 20190215151732_new_pr_Mesa1811 branch February 19, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants