Skip to content

fix defining tmp_logdir config setting and check for location of easyconfig files#763

Merged
boegel merged 4 commits intoeasybuilders:developfrom
boegel:fix_unit_tests
Mar 20, 2014
Merged

fix defining tmp_logdir config setting and check for location of easyconfig files#763
boegel merged 4 commits intoeasybuilders:developfrom
boegel:fix_unit_tests

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 20, 2014

also fixes issue reported by @wdpypere (via #739)

Comment thread test/easyconfigs/easyconfigs.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get rid of leading .*, use raw text

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .* has to be there, since I'm doing a .match rather than .search

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to \S*

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, hold on, no, I can't, I shouldn't make too much assumptions about the parent path...

@stdweird
Copy link
Copy Markdown
Contributor

looks ok

@stdweird
Copy link
Copy Markdown
Contributor

@boegel ok

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 20, 2014

Jenkins gives the green light, but the tests are bloody slow... I'll merge it in, and try and figure out why they're so slow suddenly (I already checked to make sure that the new test is not to blame, running it in isolation is very fast, cfr. https://jenkins1.ugent.be/view/EasyBuild%20(user-specific)/job/easybuild-easyconfigs_unit-test_boegel_test_/7/console).

boegel added a commit that referenced this pull request Mar 20, 2014
fix defining tmp_logdir config setting and check for location of easyconfig files
@boegel boegel merged commit 155ef71 into easybuilders:develop Mar 20, 2014
@boegel boegel deleted the fix_unit_tests branch March 20, 2014 17:31
@fgeorgatos
Copy link
Copy Markdown
Contributor

Test report by @fgeorgatos
SUCCESS
Build succeeded for 0 out of 0
Linux debian 6.0.9, Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz, Python 2.6.6
See https://gist.github.com/6349c4e8e59cab5c5eba for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants