Skip to content

{math}[foss/2017b,intel/2017b] MATLAB-Engine v2018b#7758

Merged
boegel merged 23 commits intoeasybuilders:developfrom
vanzod:20190227143820_new_pr_MATLAB-EngineR2018b
Mar 7, 2019
Merged

{math}[foss/2017b,intel/2017b] MATLAB-Engine v2018b#7758
boegel merged 23 commits intoeasybuilders:developfrom
vanzod:20190227143820_new_pr_MATLAB-EngineR2018b

Conversation

@vanzod
Copy link
Copy Markdown
Member

@vanzod vanzod commented Feb 27, 2019 •
edited by boegel
Loading

Depends on:
#7759 (MATLAB-2018b)

@vanzod
adding easyconfigs: MATLAB-Engine-R2018b-foss-2017b-Python-2.7.14.eb,…
da25df6 
… MATLAB-Engine-R2018b-foss-2017b-Python-3.6.3.eb
@vanzod vanzod added the new label Feb 27, 2019
@vanzod vanzod requested a review from boegel February 27, 2019 20:39
@vanzod vanzod added this to the 3.x milestone Feb 27, 2019
@vanzod vanzod changed the title {math}[foss/2017b] MATLAB-Engine vR2018b {math}[foss/2017b,intel/2017b] MATLAB-Engine vR2018b Feb 27, 2019
@vanzod vanzod changed the title {math}[foss/2017b,intel/2017b] MATLAB-Engine vR2018b {math}[foss/2017b,intel/2017b] MATLAB-Engine v2018b Feb 28, 2019
boegel
boegel reviewed Mar 1, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/m/MATLAB-Engine/MATLAB-Engine-2018b-foss-2017b-Python-2.7.14.eb Outdated
@easybuilders easybuilders deleted a comment from boegelbot Mar 1, 2019
@easybuilders easybuilders deleted a comment from boegelbot Mar 1, 2019
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Mar 4, 2019

@boegel Since we established that there is no easy way to install this with pip, is it good to go?

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 5, 2019

@vanzod We'll need to fix the failing test, it's tripping over the 2018b version for MATLAB-Engine...

And we'll need to add a whitelist for not using pip for MATLAB-Engine.

@boegel boegel mentioned this pull request Mar 6, 2019
Merged
vanzod and others added 2 commits March 6, 2019 16:20
@vanzod
Merge pull request #3 from boegel/20190227143820_new_pr_MATLAB-Engine…
242de29 
…R2018b

add whitelist for Python packages that don't support installation with pip
@boegel
filter out false positive match for MATLAB-Engine 2018b in test for d…
a901a32 
…ependency variants
@boegel boegel mentioned this pull request Mar 7, 2019
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2019

@vanzod Issue with 2018b version triggering a false positive in dependency variants check should be fixed with vanzod#4

vanzod and others added 2 commits March 7, 2019 07:51
@vanzod
Merge pull request #4 from boegel/20190227143820_new_pr_MATLAB-Engine…
174f989 
…R2018b

filter out false positive match for MATLAB-Engine 2018b in test for dependency variants
@vanzod
Added download_dep_fail
1ba7a46
@easybuilders easybuilders deleted a comment from boegelbot Mar 7, 2019
@easybuilders easybuilders deleted a comment from boegelbot Mar 7, 2019
@boegel boegel mentioned this pull request Mar 7, 2019
Merged
@vanzod
Merge pull request #5 from boegel/20190227143820_new_pr_MATLAB-Engine…
43c74b7 
…R2018b

fix download_dep_fail check for easyconfigs using PythonBundle
@easybuilders easybuilders deleted a comment from boegelbot Mar 7, 2019
@boegel boegel modified the milestones: 3.x, next release (3.8.2) Mar 7, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2109.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/27872e6448dcd81caebca614676e2ebb for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2525.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c3e233f9d6b396537a399156be81c15a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 7, 2019

Going in, thanks @vanzod!

@boegel boegel merged commit 37d8d9f into easybuilders:develop Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vanzod @boegel