Skip to content

avoid use of .items() in R (bundle) easyconfigs#7791

Merged
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:R_no_items
Mar 2, 2019
Merged

avoid use of .items() in R (bundle) easyconfigs#7791
akesandgren merged 2 commits intoeasybuilders:developfrom
boegel:R_no_items

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 2, 2019

Note: adding checksums for these old R-* easyconfigs that involve a lot of extensions (many of which the sources have disappeared into thin air already, I'm looking at you Bioconductor) is close to impossible, so I've temporarily disabled the checksum requirement for R-* easyconfigs in
bc11d6a (I'll roll that back as soon as this PR is merged).

@boegel boegel added this to the next release (3.8.2) milestone Mar 2, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 2, 2019

The main motivation for this is getting rid of the use of .items(), which causes trouble on top of Python 3 (see also #7778), as follows:

$ eb R-3.1.2-intel-2015a.eb -D
== temporary log file in case of crash /tmp/eb-csqvm2w8/easybuild-numdnde8.log
ERROR: Failed to process easyconfig /tmp/easybuild-easyconfigs/easybuild/easyconfigs/r/R/R-3.1.2-intel-2015a.eb: Parsing easyconfig file failed: unsupported operand type(s) for +: 'dict_items' and 'list' (line 66)

akesandgren
akesandgren approved these changes Mar 2, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 2, 2019

Test report by @boegel
SUCCESS
Build succeeded for 9 out of 9 (9 easyconfigs in this PR)
node2092.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a0769a5e5c62ee955562964977ed2e8c for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Mar 2, 2019

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 7b80a7f into easybuilders:develop Mar 2, 2019
@boegel boegel mentioned this pull request Mar 2, 2019
Merged
@boegel boegel deleted the R_no_items branch March 2, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @akesandgren