Skip to content

{chem}[intel/2018b] Bader v1.03#7804

Merged
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20190305090842_new_pr_Bader103
Mar 11, 2019
Merged

{chem}[intel/2018b] Bader v1.03#7804
boegel merged 3 commits intoeasybuilders:developfrom
migueldiascosta:20190305090842_new_pr_Bader103

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Mar 5, 2019

(created using eb --new-pr)

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Mar 5, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/7d29ef4c01233cb3e5cd2babc257f71d for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Mar 5, 2019

Test report by @migueldiascosta
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/fe87af4deece9aaed1a99aa9288ffc37 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Mar 5, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/0560ba6def13fb790c215e021820187a for a full test report.

@migueldiascosta migueldiascosta mentioned this pull request Mar 5, 2019
Merged
akesandgren
akesandgren previously requested changes Mar 8, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/b/Bader/Bader-1.03-intel-2018b.eb Outdated
sources = [{'download_filename': 'bader.tar.gz', 'filename': SOURCE_TAR_GZ}]
checksums = ['3de8af94bd64c43812de7ebad3e9209cc5e29e6732679fcf88f72a1b382bc81a']

skipsteps = ['configure']
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no configure step to skip with MakeCp, you can however turn it on by using "with_configure = True"

Copy link
Copy Markdown
Member

@boegel boegel Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, please drop

@boegel boegel added this to the 3.x milestone Mar 8, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2402.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ee52400307b6aa8a142168aa2d8aed23 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2098.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/816f5f759010be7ae134e4a0da71874a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3118.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/748378346616b46a4b743ab4beeb44ab for a full test report.

boegel
boegel approved these changes Mar 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 11, 2019

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 3af436a into easybuilders:develop Mar 11, 2019
@boegel boegel modified the milestones: 3.x, next release (3.8.2) Mar 11, 2019
@migueldiascosta migueldiascosta deleted the 20190305090842_new_pr_Bader103 branch October 2, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@akesandgren akesandgren akesandgren left review comments

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@migueldiascosta @boegel @akesandgren