Skip to content

add PyTorch to whitelist for not having 'use_pip' enabled#7844

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:pytorch_pip_whitelist
Mar 9, 2019
Merged

add PyTorch to whitelist for not having 'use_pip' enabled#7844
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:pytorch_pip_whitelist

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Mar 9, 2019

relevant for #7603 and various other current (& future) PyTorch PRs since we've put #7754 in place...

@boegel boegel added the change label Mar 9, 2019
@boegel boegel added this to the next release (3.8.2) milestone Mar 9, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Mar 9, 2019

@vanzod did an effort to try and get it working with pip, see #7717 (comment)

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 34ccd26 into easybuilders:develop Mar 9, 2019
@boegel boegel deleted the pytorch_pip_whitelist branch March 9, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants