Skip to content

Use pip instead of setup.py with h5py/2.7.1 and 2017b toolchains#7864

Merged
wpoely86 merged 4 commits intoeasybuilders:developfrom
vanzod:20190311170744_new_pr_h5py271
Mar 14, 2019
Merged

Use pip instead of setup.py with h5py/2.7.1 and 2017b toolchains#7864
wpoely86 merged 4 commits intoeasybuilders:developfrom
vanzod:20190311170744_new_pr_h5py271

Conversation

@vanzod
Copy link
Copy Markdown
Member

@vanzod vanzod commented Mar 11, 2019

(created using eb --new-pr)

@vanzod vanzod added the update label Mar 11, 2019
@vanzod vanzod changed the title Use pip instead of setup.py Use pip instead of setup.py with h5py/2.7.1 and 2017b toolchains Mar 11, 2019
@vanzod vanzod requested a review from boegel March 11, 2019 22:09
@vanzod vanzod added this to the 3.x milestone Mar 11, 2019
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Mar 11, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in this PR)
cermis - Linux debian 9.8, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/14726ae667789859f99ebdfa7cbec520 for a full test report.

boegel
boegel previously requested changes Mar 12, 2019
prebuildopts = ' python setup.py configure --mpi --hdf5=$EBROOTHDF5 && '
# To really use mpi enabled hdf5 we now seem to need a configure step
# Works with pip. Tested with examples in http://docs.h5py.org/en/stable/mpi.html
preinstallopts = ' python setup.py configure --mpi --hdf5=$EBROOTHDF5 && '
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzod Please move this down below the dependencies block while you're at it?

@boegel boegel added the change label Mar 12, 2019
vanzod added a commit to vanzod/easybuild-easyconfigs that referenced this pull request Mar 13, 2019
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Mar 13, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in this PR)
cermis - Linux debian 9.8, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/76e4871d0a0cbe09fe670357ca2b56f2 for a full test report.

@wpoely86 wpoely86 dismissed boegel’s stale review March 14, 2019 08:06

changes done

@wpoely86 wpoely86 merged commit 4ab758b into easybuilders:develop Mar 14, 2019
@easybuilders easybuilders deleted a comment from boegelbot Mar 14, 2019
@boegel boegel modified the milestones: 3.x, next release (3.8.2) Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants