Skip to content

Fix LWM2, OTF2, OPARI2, and Score-P download URLs#7994

Merged
boegel merged 5 commits intoeasybuilders:developfrom
geimer:fix_scorep_urls
Apr 4, 2019
Merged

Fix LWM2, OTF2, OPARI2, and Score-P download URLs#7994
boegel merged 5 commits intoeasybuilders:developfrom
geimer:fix_scorep_urls

Conversation

@geimer
Copy link
Copy Markdown
Contributor

@geimer geimer commented Apr 2, 2019

The URLs have changed due to an CMS upgrade 😒

@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Apr 2, 2019

Test report by @geimer
SUCCESS
Build succeeded for 19 out of 19 (19 easyconfigs in this PR)
swat - Linux debian 9.7, Intel(R) Xeon(R) CPU X5550 @ 2.67GHz, Python 2.7.13
See https://gist.github.com/cca57b9346dda842bb11833626864dc8 for a full test report.

@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Apr 2, 2019

Hmm... Since I only changed the download URLs in existing easyconfigs, I have no clue what Travis is complaining about. Any hint would be appreciated.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 2, 2019

@geimer Tests fail because of a bug in framework, fix is being added via easybuilders/easybuild-framework#2825, we'll re-trigger the tests here as soon as the fix is merged...

Two things though:

  • there's little point in fixing the archived easyconfigs

  • for all easyconfigs touched in PRs, we now require that SHA256 checksums are in place for all sources/patches... (and that's actually very relevant here, we want to make sure the downloaded tarballs remain the same as before)

@boegel boegel added the bug fix label Apr 2, 2019
@boegel boegel added this to the 3.9.0 milestone Apr 2, 2019
@vanzod vanzod closed this Apr 2, 2019
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Apr 2, 2019

Re-trigger travis after fix

@vanzod vanzod reopened this Apr 2, 2019
@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Apr 3, 2019

@boegel: SHA256 checksums are now in place. Regarding archived easyconfigs: I think there is little point in keeping them if they are known to be broken. So either we fix them (if it's about checksums and URLs) or delete them entirely.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2019

@geimer The archived easyconfigs will be trashed in the upcoming EasyBuild v4.0, but there other EasyBuild releases where they are still included.

I don't strongly object fixing them as well, but it may be more hassle than it's worth (they're only picked up if people configure EasyBuild with --consider-archived-easyconfigs).

I've re-triggered the tests now the problems in framework have been resolved, but it seems like there's one more issue you should take care of:

AssertionError: Failed to find parsed easyconfig for LWM2-1.1-gompi-1.4.12-no-OFED.eb

(let's see if that's still there when the tests complete again though)

@easybuilders easybuilders deleted a comment from boegelbot Apr 3, 2019
@easybuilders easybuilders deleted a comment from boegelbot Apr 3, 2019
@easybuilders easybuilders deleted a comment from boegelbot Apr 3, 2019
@easybuilders easybuilders deleted a comment from boegelbot Apr 3, 2019
@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Apr 3, 2019

@boegel The archived easyconfigs are now fixed as well, so no additional work to do in this regard. The easyconfig mentioned in the assertion is actually one of them -- and it is there:

$ find . -name LWM2-1.1-gompi-1.4.12-no-OFED.eb
./easybuild/easyconfigs/__archive__/l/LWM2/LWM2-1.1-gompi-1.4.12-no-OFED.eb

Not sure what is going one here...

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 3, 2019

@geimer It may be a side effect of touching archived easyconfigs, some tests may not be aware of that.

Let me take a look at it when it fails again, could be an easy fix.

@boegelbot
Copy link
Copy Markdown
Collaborator

Travis test report: 2/2 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/515065468

Only showing partial log for 1st failed test suite run 14013.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/515065469

...
FAIL: Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 464, in test_changed_files_pull_request
    self.assertTrue(False, "Failed to find parsed easyconfig for %s" % ec_fn)
AssertionError: Failed to find parsed easyconfig for LWM2-1.1-gompi-1.4.12-no-OFED.eb

----------------------------------------------------------------------
Ran 10943 tests in 1009.593s

FAILED (failures=1)
ERROR: Not all tests were successful.

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 4, 2019

@geimer Please see if geimer#5 fixes the tests tripping over the fact that you're changing archived easyconfigs...

also consider archived easyconfigs in test_changed_files_pull_request
@geimer
Copy link
Copy Markdown
Contributor Author

geimer commented Apr 4, 2019

@boegel This seems to do the trick. Thanks!

@boegel boegel changed the title Fix OTF2, OPARI2, and Score-P download URLs Fix LWM2, OTF2, OPARI2, and Score-P download URLs Apr 4, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 4, 2019

Test report by @boegel
SUCCESS
Build succeeded for 209 out of 209 (19 easyconfigs in this PR)
node2055.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a5174bfdda2ad45b31533c42af4255d4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 4, 2019

Going in, thanks @geimer!

@boegel boegel merged commit f997a37 into easybuilders:develop Apr 4, 2019
@geimer geimer deleted the fix_scorep_urls branch May 9, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants