Skip to content

add an additional env variable $GRACE_HOME to Grace easyconfigs, so that font dir can be located#8048

Merged
boegel merged 3 commits intoeasybuilders:developfrom
murfreesboro:20190410110550_new_pr_Grace5125
May 7, 2019
Merged

add an additional env variable $GRACE_HOME to Grace easyconfigs, so that font dir can be located#8048
boegel merged 3 commits intoeasybuilders:developfrom
murfreesboro:20190410110550_new_pr_Grace5125

Conversation

@murfreesboro
Copy link
Copy Markdown
Contributor

@murfreesboro murfreesboro commented Apr 10, 2019

(created using eb --new-pr)

@migueldiascosta migueldiascosta added this to the 3.9.0 milestone Apr 11, 2019
@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Apr 11, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
grc-cluster1 - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2640 0 @ 2.50GHz, Python 2.7.14
See https://gist.github.com/73e01e7842ad8309d45031797d536226 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Apr 11, 2019

@murfreesboro might as well also fix the older easyconfig, Grace-5.1.25-foss-2018a-5build1.eb?

@hajgato that one was contributed by you in #6036, any objections?

@murfreesboro
Copy link
Copy Markdown
Contributor Author

murfreesboro commented Apr 11, 2019

@migueldiascosta yeah I agree. We may also need to fix the 2018a version, too.

@hajgato
Copy link
Copy Markdown
Collaborator

hajgato commented Apr 11, 2019

@murfreesboro @migueldiascosta Go ahead!

@boegel boegel modified the milestones: 3.9.0, next release (3.9.1) Apr 12, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2019

@murfreesboro Please make the same change to Grace-5.1.25-foss-2018a-5build1.eb so we can go ahead and merge this?

@murfreesboro
Copy link
Copy Markdown
Contributor Author

murfreesboro commented May 3, 2019

OK @boegel will do it on Monday.

@murfreesboro
Copy link
Copy Markdown
Contributor Author

murfreesboro commented May 7, 2019

@boegel the change for 2018a is in.

@boegel boegel changed the title add an additional env variable of GRACE_HOME, so that to locate the font dir add an additional env variable $GRACE_HOME to Grace easyconfigs, so that font dir can be located May 7, 2019
boegel
boegel approved these changes May 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 7, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2006.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/dcb456b676261a77b3b06f8e47828364 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 7, 2019

Going in, thanks @murfreesboro!

@boegel boegel merged commit 9cc303f into easybuilders:develop May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@murfreesboro @migueldiascosta @hajgato @boegel