Skip to content

$XDG_DATA_DIRS must be set for GTK+#8089

Merged
boegel merged 5 commits intoeasybuilders:developfrom
akesandgren:20190419085329_new_pr_GTK+3248
Apr 24, 2019
Merged

$XDG_DATA_DIRS must be set for GTK+#8089
boegel merged 5 commits intoeasybuilders:developfrom
akesandgren:20190419085329_new_pr_GTK+3248

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Apr 19, 2019

(created using eb --new-pr)

@akesandgren akesandgren added this to the next release (3.9.1) milestone Apr 19, 2019
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Apr 19, 2019

If this is also required by the version 2.24.x available in the older toolchains, it may be worth fixing them all in this PR.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Apr 19, 2019

@boegel what do you say? How far back should we fix this?

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2019

@akesandgren Why not fix all of them, or at least the ones using a non-deprecated toolchain?

The change is quite trivial (it can be tested with --module-only).

@boegel boegel changed the title GTK+ must set XDG_DATA_DIRS $XDG_DATA_DIRS must be set for GTK+ Apr 24, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2019

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (12 easyconfigs in this PR)
node2003.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/774aced72edff9c3f6e07dfda21b62b0 for a full test report.

boegel
boegel previously approved these changes Apr 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2019

@akesandgren You'll need to add the missing checksums too for the older GTK+ easyconfigs...

@akesandgren akesandgren mentioned this pull request Apr 24, 2019
Merged
@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2019

@akesandgren And now you're being bitten by #8101... :)

@easybuilders easybuilders deleted a comment from boegelbot Apr 24, 2019
boegel
boegel approved these changes Apr 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Apr 24, 2019

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
b-an03.hpc2n.umu.se - Linux ubuntu 16.04, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/89c734774eaf2d1dd77ff0062fea7774 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2019

Test report by @boegel
SUCCESS
Build succeeded for 13 out of 13 (13 easyconfigs in this PR)
node2003.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/104c3c351e22a57116d43c4579cb80fc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Apr 24, 2019

Going in, thanks @akesandgren!

@boegel boegel merged commit f01e236 into easybuilders:develop Apr 24, 2019
@akesandgren akesandgren deleted the 20190419085329_new_pr_GTK+3248 branch April 24, 2019 12:09
@akesandgren akesandgren mentioned this pull request May 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@vanzod vanzod Awaiting requested review from vanzod

@verdurin verdurin Awaiting requested review from verdurin

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @vanzod @boegel