{bio}[goolf/1.4.10] Minimac 20140110 (REVIEW)#815
{bio}[goolf/1.4.10] Minimac 20140110 (REVIEW)#815boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
SUCCESS |
|
looks good - and PR worked, too! |
There was a problem hiding this comment.
btw. the location of this comma is a bit weird; is this really the intended style?
|
Test report by @fgeorgatos |
|
Test report by @boegel |
|
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Hi folks,
I try to enter into Pablo's mind and I think he would have liked to propose instead:
version = '2013.7.17'
versionsuffix = '-a8011a4'
More generally, for nasty version-less applications we should adopt an ad-hoc format like:
version = '20130717'
versionsuffix = '-a8011a4' # or any other hash for that matter
The point is:
- Make it possible to sort sanely, by temporal aspects / release time
- Confine the version/naming sufficiently to make the builds truly unique.
Your takes?
There was a problem hiding this comment.
makes sense, yeah
We should be using the datestamp in the source tarball name too, but that breaks auto-downloading.
There was a problem hiding this comment.
on second thought, just specifying a datestamp as 'version' as using that in the source name should do it, no need to add a hash as a version suffix (the datestamp serves that purpose, together with the specified MD5sum being checked)
|
Test report by @rjeschmi |
There was a problem hiding this comment.
include datestamp/version in source tarball name (breaks auto-downloading, but that's not a big issue imho)
# download minimac.src.tgz from http://www.sph.umich.edu/csg/cfuchsb and rename
sources = ['%(namelower)s-%(version)s.src.tgz']|
@pescobar: please review/merge pescobar#13, so we can get this one merged in... |
fix Minimac 'version'
|
Refer to this link for build results (access rights to CI server needed): |
|
Test report by @boegel |
|
(finally) going in, thanks @pescobar, and @fgeorgatos, @rjeschmi for testing/reviewing |
{bio}[goolf/1.4.10] Minimac 20140110 (REVIEW)
No description provided.