Skip to content

R: make sure hdf5r picks up HDF5 from EasyBuild#8223

Merged
boegel merged 3 commits intoeasybuilders:developfrom
smoors:20190502200811_new_pr_R351
May 8, 2019
Merged

R: make sure hdf5r picks up HDF5 from EasyBuild#8223
boegel merged 3 commits intoeasybuilders:developfrom
smoors:20190502200811_new_pr_R351

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented May 2, 2019

(created using eb --new-pr)

@smoors smoors added the bug fix label May 2, 2019
boegel
boegel reviewed May 2, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/r/R/R-3.5.1-foss-2018b-Python-2.7.15.eb
boegel
boegel reviewed May 2, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/r/R/R-3.5.1-foss-2018b-Python-2.7.15.eb Outdated
'checksums': ['58e36d3b8a67d01194c4e5099499657d017f77fc2081213633964b1d57a7e32f'],
}),
('hdf5r', '1.0.0', {
'installopts': '--configure-args="--with-hdf5=$EBROOTHDF5/bin/h5pcc"',
Copy link
Copy Markdown
Member

@boegel boegel May 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors What goes wrong if this is not used?

Copy link
Copy Markdown
Contributor Author

@smoors smoors May 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there is a system HDF5 present, hdf5r will use that one.

Copy link
Copy Markdown
Contributor Author

@smoors smoors May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and if the system HDF5 is too old, build will fail.

@boegel boegel added this to the next release (3.9.1) milestone May 2, 2019
@boegel boegel self-assigned this May 8, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

I'll take care of this once #8020 is merged (since the same fix for hdf5r should be applied in there too)

boegel
boegel approved these changes May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2001.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ccd818d6e238eb41a94283d986cb1cb7 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Going in, thanks @smoors!

@boegel boegel merged commit 6f00e03 into easybuilders:develop May 8, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3118.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/5e395d1f9dddc7b0dac5af07132e7203 for a full test report.

@boegel boegel mentioned this pull request May 14, 2019
Closed
@boegel boegel changed the title R: make sure hdf5r picks up HDF5 from EB + fix checksum R: make sure hdf5r picks up HDF5 from EasyBuild May 15, 2019
@smoors smoors deleted the 20190502200811_new_pr_R351 branch January 15, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

@boegel boegel

Labels

bug fix merge sprint

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@smoors @boegel