Skip to content

add missing Ruby dep (& Python build dep) for WebKitGTK+ v2.24.1#8241

Merged
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20190504165209_new_pr_WebKitGTK+2241
May 8, 2019
Merged

add missing Ruby dep (& Python build dep) for WebKitGTK+ v2.24.1#8241
boegel merged 1 commit intoeasybuilders:developfrom
akesandgren:20190504165209_new_pr_WebKitGTK+2241

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented May 4, 2019 •
edited
Loading

(created using eb --new-pr)
Depends on #8239.

@akesandgren akesandgren added this to the next release (3.9.1) milestone May 4, 2019
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented May 4, 2019

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
b-an03.hpc2n.umu.se - Linux ubuntu 16.04, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/0450c334d9725211e8fd288587c32077 for a full test report.

@boegel boegel changed the title {lib}[GCC/8.2.0-2.31.1] WebKitGTK+ v2.24.1 add missing Ruby dep (& Python build dep) for WebKitGTK+ v2.24.1 May 5, 2019
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented May 5, 2019

Kicking travis with Ruby merged.

@akesandgren akesandgren closed this May 5, 2019
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented May 5, 2019

Travis kicked

@akesandgren akesandgren reopened this May 5, 2019
@easybuilders easybuilders deleted a comment from boegelbot May 5, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 5, 2019 •
edited
Loading

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2567.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/059fbf69916fcbbfa0bf8b7a32d83ced for a full test report.

edit: failed because Harfbuzz was not rebuilt with #8226, will submit new test report...

@boegel
Copy link
Copy Markdown
Member

boegel commented May 5, 2019

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2567.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/df1aa9a35b42d3aaff65d2e5e7dfe84e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 5, 2019

@akesandgren Now fails with Couldn't find include 'Gtk-3.0.gir'... Is that another thing you have installed OS-wide while we don't?

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented May 5, 2019 •
edited by boegel
Loading

I might have, but the problem is caused by a missing GI_TYPELIB_PATH in the GTK-3 easyconfig.
Fixed in #8246

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2406.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/f74b42a804b03e716898822452752261 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
node2404.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/a62097f0be4aaa102db53fdac799964a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

@akesandgren Nevermind that, need to re-generate my GTK+ module to include the fix from #8246...

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2404.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/7334fafabf8bdb37df82fb2d61a0adc1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3118.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/818500615c24ff329aada1e3668082f1 for a full test report.

boegel
boegel approved these changes May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2039.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/55f799c759da37bcf18db8d15df06178 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 8, 2019

Going in, thanks @akesandgren!

@boegel boegel merged commit 195f573 into easybuilders:develop May 8, 2019
@akesandgren akesandgren deleted the 20190504165209_new_pr_WebKitGTK+2241 branch May 8, 2019 16:15
@akesandgren akesandgren mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix merge sprint

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@akesandgren @boegel