Skip to content

Make the requirement on Python clear for GLib. Fix python shebang.#8277

Merged
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:20190509104349_new_pr_GLib2601
May 9, 2019
Merged

Make the requirement on Python clear for GLib. Fix python shebang.#8277
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:20190509104349_new_pr_GLib2601

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@akesandgren
Copy link
Copy Markdown
Contributor Author

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
b-an03.hpc2n.umu.se - Linux ubuntu 16.04, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/d522f9979a47e58d88191f8fc8f01c09 for a full test report.

@akesandgren akesandgren added this to the next release (3.9.1) milestone May 9, 2019
@akesandgren akesandgren requested a review from Micket May 9, 2019 08:52
akesandgren added a commit to akesandgren/easybuild-easyconfigs that referenced this pull request May 9, 2019
@Micket
Copy link
Copy Markdown
Contributor

Micket commented May 9, 2019

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
hebbe-s1.int.private - Linux centos 6.10, Intel(R) Xeon(R) CPU E5-2650 v3 @ 2.30GHz, Python 2.7.14
See https://gist.github.com/7344efd5db666c237f6a09a003f0e71b for a full test report.

Micket
Micket previously approved these changes May 9, 2019
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread easybuild/easyconfigs/g/GLib/GLib-2.60.1-GCCcore-8.2.0.eb Outdated
configopts = "--buildtype=release --default-library=both "

postinstallcmds = ["sed -i -e 's|#!.*python|#!/usr/bin/env python|' %(installdir)s/bin/*"]
postinstallcmds = ["sed -i -e 's|#!.*python[0-9.]*$|#!/usr/bin/env python|' %(installdir)s/bin/*"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good use case for easybuilders/easybuild-framework#2869

Doesn't need to block this PR, but we should change this easyconfig once we have global support for fix_python_shebang_for...

@boegel
Copy link
Copy Markdown
Member

boegel commented May 9, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2006.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a51d2824e822509c587469807be58f8d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 9, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2557.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/82c3d254e27ae4c68eeb582745fc70fc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 9, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3122.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/f3d4f854f5e5b0dd60eb6a5154360563 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 9, 2019

Going in, thanks @akesandgren!

@boegel boegel merged commit 96e7d6c into easybuilders:develop May 9, 2019
@akesandgren akesandgren deleted the 20190509104349_new_pr_GLib2601 branch May 9, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants