Skip to content

Add missing $GI_TYPELIB_PATH to Pango module. Everything that uses GObject-Introspection should have this set.#8286

Merged
boegel merged 5 commits intoeasybuilders:developfrom
akesandgren:20190510080035_new_pr_Pango1430
May 12, 2019
Merged

Add missing $GI_TYPELIB_PATH to Pango module. Everything that uses GObject-Introspection should have this set.#8286
boegel merged 5 commits intoeasybuilders:developfrom
akesandgren:20190510080035_new_pr_Pango1430

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented May 10, 2019

(created using eb --new-pr)

@akesandgren akesandgren added this to the next release (3.9.1) milestone May 10, 2019
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented May 10, 2019

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
b-an03.hpc2n.umu.se - Linux ubuntu 16.04, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 2.7.12
See https://gist.github.com/e78780ca2ca17669306d458598b4ea7c for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented May 10, 2019

@akesandgren interestingly, 3 of the older easyconfigs have it, but many more don't, can you also add it to those?

@easybuilders easybuilders deleted a comment from boegelbot May 10, 2019
@easybuilders easybuilders deleted a comment from boegelbot May 10, 2019
boegel
boegel approved these changes May 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, test report coming up...

@boegel
Copy link
Copy Markdown
Member

boegel commented May 10, 2019

Test report by @boegel
FAILED
Build succeeded for 15 out of 17 (17 easyconfigs in this PR)
node2079.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/7d04e291d656b240f46d6c9394712aa5 for a full test report.

boegel
boegel requested changes May 10, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/p/Pango/Pango-1.40.1-foss-2016a.eb Outdated
Comment thread easybuild/easyconfigs/p/Pango/Pango-1.40.1-intel-2016a.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented May 11, 2019

Test report by @boegel
SUCCESS
Build succeeded for 17 out of 17 (17 easyconfigs in this PR)
node2068.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a7bba1ab08643464c4fea848e40b21f4 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 12, 2019

Going in, thanks @akesandgren!

@boegel boegel merged commit bd9e1a8 into easybuilders:develop May 12, 2019
@akesandgren akesandgren deleted the 20190510080035_new_pr_Pango1430 branch May 12, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@migueldiascosta migueldiascosta Awaiting requested review from migueldiascosta

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @migueldiascosta @boegel