Skip to content

{bio}[foss/2018b] cytosim v20190117#8368

Merged
boegel merged 9 commits intoeasybuilders:developfrom
sassy-crick:20190522171201_new_pr_cytosimmaster20190117
Sep 14, 2019
Merged

{bio}[foss/2018b] cytosim v20190117#8368
boegel merged 9 commits intoeasybuilders:developfrom
sassy-crick:20190522171201_new_pr_cytosimmaster20190117

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

(created using eb --new-pr)

…ent.eb, cytosim-master-20190117-foss-2018b-mkl-3D-png-detachment.eb, cytosim-master-20190117-foss-2018bmkl-3D-png.eb, cytosim-master-20190117-foss-2018b-mkl-3D.eb, cytosim-master-20190117-foss-2018b-mkl-detachment.eb, cytosim-master-20190117-foss-2018b-mkl-detachment.eb, cytosim-master-20190117-foss-2018b-mkl-png-detachment.eb, cytosim-master-20190117-foss-2018b-mkl-png.eb, cytosim-master-20190117-foss-2018b-mkl.eb and patches: 3D.patch, detachment.patch, mkl.patch, png.patch
@boegel boegel added the new label May 23, 2019
@boegel boegel added this to the 3.x milestone May 23, 2019
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the patch files so they start with cytosim-%(version)s, and include a short description + mention of author at the top of each patch file.

Are all the combination actually needed btw?

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegel I done the renaming of the patch files and included the cytosim-%(version)s changes inside the build files for the name of the patches. I did leave the comments behind the checksum though as it would get too long I feared.
These were basically all the permutations the user requested so I thought I might as well make them available. Before I upload all of them, we could merge all of that in one file and let users comment out the features they want to use. However, I am not sure if people would understand that correctly. Let me know please.

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegel I done the renaming of the patch files and included the cytosim-%(version)s changes inside the build files for the name of the patches. I did leave the comments behind the checksum though as it would get too long I feared.
These were basically all the permutations the user requested so I thought I might as well make them available. I merge all of them in one file and let users comment out the features they want to use. Let me know what you think of that please.

@migueldiascosta
Copy link
Copy Markdown
Member

@sassy-crick your last commit simply removed all the eb files

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

I have uploaded the EB build file and the patch files again. I am not sure how that happened. I have slightly updated the EB build file by replacing the full name of the patch file, instead of a shorter version.

@easybuilders easybuilders deleted a comment from boegelbot Sep 14, 2019
@easybuilders easybuilders deleted a comment from boegelbot Sep 14, 2019
@easybuilders easybuilders deleted a comment from boegelbot Sep 14, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2400.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/fcd0303035b7c1d6a97e7e6dcc360ea0 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3110.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/935c97e72afbceac5256ea180b8bc25a for a full test report.

@boegel boegel changed the title {bio}[foss/2018b] cytosim vmaster-20190117 {bio}[foss/2018b] cytosim v20190117 Sep 14, 2019
@boegel boegel modified the milestones: 3.x, 4.0.0 Sep 14, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 14, 2019

Going in, thanks @sassy-crick!

@boegel boegel merged commit 496be67 into easybuilders:develop Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants