Skip to content

workaround for the OpenBLAS v0.3.1 matrices multiplication issue#8396

Merged
boegel merged 7 commits intoeasybuilders:developfrom
pescobar:openblas-matrix-fix
May 28, 2019
Merged

workaround for the OpenBLAS v0.3.1 matrices multiplication issue#8396
boegel merged 7 commits intoeasybuilders:developfrom
pescobar:openblas-matrix-fix

Conversation

@pescobar
Copy link
Copy Markdown
Member

@pescobar pescobar commented May 28, 2019 •
edited
Loading

kudos to @cfenoy for figuring out this

@easybuilders easybuilders deleted a comment from boegelbot May 28, 2019
boegel
boegel requested changes May 28, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.1-GCC-7.3.0-2.30.eb Outdated
Comment thread easybuild/easyconfigs/o/OpenBLAS/OpenBLAS-0.3.1-GCC-7.3.0-2.30.eb
@boegel boegel added the bug fix label May 28, 2019
@boegel boegel added this to the next release (3.9.2) milestone May 28, 2019
@boegel boegel changed the title workaround for the openblas matrices multiplication issue workaround for the OpenBLAS v0.3.1 matrices multiplication issue May 28, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented May 28, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2022.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/0672700f3673849e98367bf6a1bb0e4f for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 28, 2019

I was able to reproduce the problem on both Intel Sandy Bridge and Intel Haswell using the scripts from https://github.com/eylenth/Openblas_matrix_issue, and the problem was indeed resolved after rebuilding OpenBLAS 0.3.1 using this patch.

Thanks a lot @cfenoy!

@boegel
Copy link
Copy Markdown
Member

boegel commented May 28, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3121.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/bd2d323828c3f4593030a0057e9feb4b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 28, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2499.golett.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c07862385b442b8121160b1535a994a5 for a full test report.

boegel
boegel approved these changes May 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 28, 2019

Going in, thanks @pescobar!

@boegel boegel merged commit 69b3ec3 into easybuilders:develop May 28, 2019
@smoors smoors mentioned this pull request May 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@pescobar @boegel