Skip to content

{vis}[foss/2017b,intel/2017b] ciftify v2.3.2.post1 w/ Python 3.6.3#8457

Merged
smoors merged 2 commits intoeasybuilders:developfrom
vanzod:20190607085457_new_pr_ciftify232post1
Jun 11, 2019
Merged

{vis}[foss/2017b,intel/2017b] ciftify v2.3.2.post1 w/ Python 3.6.3#8457
smoors merged 2 commits intoeasybuilders:developfrom
vanzod:20190607085457_new_pr_ciftify232post1

Conversation

@vanzod
Copy link
Copy Markdown
Member

@vanzod vanzod commented Jun 7, 2019

Depends on #8450 (Nilearn)

…iftify-2.3.2.post1-intel-2017b-Python-3.6.3.eb
@vanzod vanzod added the new label Jun 7, 2019
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Jun 7, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
cermis - Linux debian 9.9, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/68aaf33272d5d5c2be1a22964c89e469 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 10, 2019

closing-reopening to trigger travis

@smoors smoors closed this Jun 10, 2019
@smoors smoors reopened this Jun 10, 2019
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 11, 2019

Test report by @smoors
FAILED
Build succeeded for 8 out of 10 (2 easyconfigs in this PR)
nic406 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/2b1623b19a8bdbfaddac4045d5c5e8f6 for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzod the error is in the setup.py file of cifity trying to read a file:
from m2r import parse_from_file\n ModuleNotFoundError: No module named 'm2r'
the fallback also fails because of non-ascii characters:
During handling of the above exception, another exception occurred:\n \n Traceback (most recent call last):\n File \"<string>\", line 1, in <module>\n File \"/tmp/smoors.2152549/eb-qYCAgy/pip-m4t1c3kt-build/setup.py\", line 14, in <module>\n readme = f.read()\n File \"/apps/brussel/CO7/skylake/software/Python/3.6.3-intel-2017b/lib/python3.6/encodings/ascii.py\", line 26, in decode\n return codecs.ascii_decode(input, self.errors)[0]\n UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 5484: ordinal not in range(128)

I guess the solution would be to add the m2r extension, or alternatively patch the setup.py file:
with open(readme_file, encoding='utf-8') as f:

@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Jun 11, 2019

@smoors It seems a safer approach to me to just go ahead and add m2r than assuming utf-8 encoding and patching setup.py.

@vanzod vanzod added this to the 3.x milestone Jun 11, 2019
@vanzod
Copy link
Copy Markdown
Member Author

vanzod commented Jun 11, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
cermis - Linux debian 9.9, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/8de68cef7b504919f588cc33d409e3b5 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 11, 2019

Test report by @smoors
SUCCESS
Build succeeded for 10 out of 10 (2 easyconfigs in this PR)
nic400 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/17ca15b107f040414e986f3d82e22668 for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 11, 2019

Going in, thanks @vanzod!

@smoors smoors merged commit 738f4bf into easybuilders:develop Jun 11, 2019
@easybuilders easybuilders deleted a comment from boegelbot Jun 12, 2019
@boegel boegel modified the milestones: 3.x, 3.9.3 Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants