Skip to content

{tools}[GCCcore/6.4.0,GCCcore/7.3.0,GCCcore/8.2.0] UnZip v6.0#8474

Merged
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:20190611090311_new_pr_UnZip60
Jul 6, 2019
Merged

{tools}[GCCcore/6.4.0,GCCcore/7.3.0,GCCcore/8.2.0] UnZip v6.0#8474
boegel merged 2 commits intoeasybuilders:developfrom
akesandgren:20190611090311_new_pr_UnZip60

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Jun 11, 2019 •
edited
Loading

(created using eb --new-pr)

@akesandgren
adding easyconfigs: UnZip-6.0-GCCcore-6.4.0.eb, UnZip-6.0-GCCcore-7.3…
5b47c18 
….0.eb, UnZip-6.0-GCCcore-8.2.0.eb and patches: 01-manpages-in-section-1-not-in-section-1l.patch, 03-include-unistd-for-kfreebsd.patch, 04-handle-pkware-verification-bit.patch, 05-fix-uid-gid-handling.patch, 06-initialize-the-symlink-flag.patch, 07-increase-size-of-cfactorstr.patch, 08-allow-greater-hostver-values.patch, 09-cve-2014-8139-crc-overflow.patch, 10-cve-2014-8140-test-compr-eb.patch, 11-cve-2014-8141-getzip64data.patch, 12-cve-2014-9636-test-compr-eb.patch, 13-remove-build-date.patch, 14-cve-2015-7696.patch, 15-cve-2015-7697.patch, 16-fix-integer-underflow-csiz-decrypted.patch, 20-unzip60-alt-iconv-utf8.patch
@akesandgren akesandgren added this to the next release (3.9.3) milestone Jun 11, 2019
@akesandgren akesandgren requested a review from boegel June 11, 2019 07:05
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 11, 2019

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
nic406 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/3d2b1363e94115921111c8f351dd0531 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 11, 2019

that's a lot of patches!

smoors
smoors previously approved these changes Jun 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Jun 11, 2019

Yeah, it's the patches from the Ubuntu packaging (well not all of them actually)

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 13, 2019

@boegel since your review is requested I'll wait for your approval before merging.

@vanzod
Copy link
Copy Markdown
Member

vanzod commented Jun 20, 2019

Test report by @vanzod
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
cermis - Linux debian 9.9, Intel(R) Xeon(R) CPU X5670 @ 2.93GHz, Python 2.7.13
See https://gist.github.com/35e1d9f7300073bd7b4fb3145d5fc25f for a full test report.

vanzod
vanzod previously approved these changes Jun 20, 2019
View reviewed changes
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2019

@akesandgren Can we stick to the usual naming scheme for patch files here, i.e. UnZip-6.0_xxx.patch, maybe combine all of these into a single patch file by cat'ing them into one?

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Jun 20, 2019

Doh... forgot to fix that.

boegel
boegel requested changes Jul 4, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/u/UnZip/UnZip-6.0-GCCcore-6.4.0.eb Outdated
@boegel boegel modified the milestones: next release (3.9.3), 3.x Jul 4, 2019
@akesandgren akesandgren dismissed stale reviews from vanzod and smoors via 54a1b09 July 5, 2019 12:22
boegel
boegel approved these changes Jul 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel modified the milestones: 3.x, next release (3.9.4?) Jul 6, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node3102.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/894f7ce38df4fe42a1b1e368fdf40f95 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2625.swalot.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/af0ea1743122d29fa7a14672859365f5 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2019

Going in, thanks @akesandgren!

@boegel boegel modified the milestones: next release (3.9.4?), 3.9.3 Jul 6, 2019
@boegel boegel merged commit 97dbaa6 into easybuilders:develop Jul 6, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 6, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in this PR)
node2102.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/78201db4bdb8c4d4805c4b490a73a5ed for a full test report.

@akesandgren akesandgren deleted the 20190611090311_new_pr_UnZip60 branch July 6, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@smoors smoors smoors left review comments

@vanzod vanzod vanzod left review comments

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.9.3

Development

Successfully merging this pull request may close these issues.

4 participants

@akesandgren @smoors @vanzod @boegel