Skip to content

{devel}[GCCcore/8.2.0] gdbgui v0.13.1.2 w/ Python 3.7.2#8488

Merged
smoors merged 4 commits intoeasybuilders:developfrom
Micket:20190613203629_new_pr_gdbgui01312
Jun 14, 2019
Merged

{devel}[GCCcore/8.2.0] gdbgui v0.13.1.2 w/ Python 3.7.2#8488
smoors merged 4 commits intoeasybuilders:developfrom
Micket:20190613203629_new_pr_gdbgui01312

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Jun 13, 2019 •
edited by boegel
Loading

(created using eb --new-pr)
depends on 8485

@Micket Micket added the new label Jun 13, 2019
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Jun 13, 2019 •
edited
Loading

And In case someone asks; this package only supports python 3 (and I want to put GDB as a dep as well).

@boegelbot

This comment has been minimized.

Sign in to view
smoors
smoors requested changes Jun 14, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/g/gdbgui/gdbgui-0.13.1.2-GCCcore-8.2.0-Python-3.7.2.eb Outdated
Comment thread easybuild/easyconfigs/g/gdbgui/gdbgui-0.13.1.2-GCCcore-8.2.0-Python-3.7.2.eb Outdated
smoors
smoors requested changes Jun 14, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/g/gdbgui/gdbgui-0.13.1.2-GCCcore-8.2.0-Python-3.7.2.eb Outdated
Comment thread easybuild/easyconfigs/g/gdbgui/gdbgui-0.13.1.2-GCCcore-8.2.0-Python-3.7.2.eb Outdated
Comment thread easybuild/easyconfigs/g/gdbgui/gdbgui-0.13.1.2-GCCcore-8.2.0-Python-3.7.2.eb Outdated
Comment thread easybuild/easyconfigs/g/gdbgui/gdbgui-0.13.1.2-GCCcore-8.2.0-Python-3.7.2.eb
'source_urls': ['https://pypi.python.org/packages/source/f/flask-socketio/'],
'checksums': ['f49edfd3a44458fbb9f7a04a57069ffc0c37f000495194f943a25d370436bb69'],
}),
('Flask', '0.12.4', {
Copy link
Copy Markdown
Contributor

@smoors smoors Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket there is already an easyconfig for Flask. given that several other codes need it too, maybe its better to update it (and add Flask-Compress, Flask-SocketIO) and add it as dependency for gdbgui?

Copy link
Copy Markdown
Contributor Author

@Micket Micket Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoors gdbgui unfortunately has a requirement for Flask < 1.0 though
https://github.com/cs01/gdbgui/blob/master/setup.py#L12
as well as a requirement on an older Flask-SocketIO

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 14, 2019

Test report by @smoors
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in this PR)
nic425 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/0789398e74ac4d3c6561aa05bd61e26a for a full test report.

smoors
smoors approved these changes Jun 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (3.9.3) milestone Jun 14, 2019
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 14, 2019

Going in, thanks @Micket!

@smoors smoors merged commit 66146d7 into easybuilders:develop Jun 14, 2019
@Micket Micket deleted the 20190613203629_new_pr_gdbgui01312 branch April 21, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

3.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegelbot @smoors