make additional configopts in PETSc easyconfigs work after uncommenting#8522
make additional configopts in PETSc easyconfigs work after uncommenting#8522boegel merged 1 commit intoeasybuilders:developfrom
Conversation
configopts related to SLURM support.
|
(close & re-open to retrigger Travis on top of |
|
@ravage Thanks a lot for your contribution, and sorry that it took us a while to pick up on it... Travis barfed at you a bit because of failing unit tests, which was caused by a combination of targeting the For future contributions, please target our |
|
Test report by @boegel |
|
@boegel Thank you for picking it up, merging and provide instructions for getting it right next time :) This was the first time submitting a PR to repositories i'm not familiar with. At first the failure caught me by surprise, but then, noticed it was a problem resolving a Python dependency. And since it was such a small change i didn't make much of it. In the future will follow the rules described in the documentation you pointed out as i should have done in the first place. |
|
@ravage Did you mean to close the PR? :) |
|
@boegel doing damage again 😱? I'll reopen it... it looks like i have no idea of what i'm doing 😂 |
|
Making mistakes are the best way to learn, don't worry about it. Only downside is that we'll have to wait for Travis again now, since it'll re-test the PR because of the close/re-open :) |
|
Going in, thanks @ravage! |
|
Sorry 😅 will step away from the keyboard! |
|
Ah, apparently not, even Travis is confused I guess... :) PR is merged now, to be included with the next EasyBuild release (v3.9.3). Thanks a lot for your contribution, keep 'em coming! 👍 |
After removing comments to enable SLURM batch support the build stops working due to malformed configure options.