{devel}[GCCcore/8.2.0] Add patch and dependencies to Qt5-5.12.3 #8544
Merged
migueldiascosta merged 11 commits intoeasybuilders:developfrom Jul 11, 2019
Merged
{devel}[GCCcore/8.2.0] Add patch and dependencies to Qt5-5.12.3 #8544migueldiascosta merged 11 commits intoeasybuilders:developfrom
migueldiascosta merged 11 commits intoeasybuilders:developfrom
Conversation
… support for 16-bit code units and unicode
…e building shared libs
…y, build with the re2c tool and include optional dependencies already available in the EB tree (double-conversion, libevent, libjpeg-turbo, snappy)
… linux-icc to define QMAKE_LIBDIR_X11 and QMAKE_LIBDIR_OPENGL with EasyBuild variables
…ould be in GCCcore toolchain
Member
|
Test report by @migueldiascosta |
migueldiascosta
approved these changes
Jul 10, 2019
Member
migueldiascosta
left a comment
There was a problem hiding this comment.
tested rebuilding the existing easyconfigs that depend on Qt5/5.12.3, lgtm
Member
|
Going in, thanks @lexming! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Qt5-5.12.3 in develop builds without support for Xlib due to QMAKE_LIBDIR_X11 and QMAKE_LIBDIR_OPENGL being hardcoded to system paths that might not exist. Those definitions come from platform dependent
qmake.conffiles enabled by configopts--platform. The following PR patches thoseqmake.conffiles with paths from EB.I also added a few dependencies to bring the build of Qt5 in EB closer in features to the builds on linux distros.
We have tested this build for the past month with no issues and QtOpenGL apps work well with it.