Skip to content

{math}[foss/2019a] qpth v0.0.13_20190626 w/ Python 3.7.2#8665

Merged
boegel merged 4 commits intoeasybuilders:developfrom
smoors:20190803081835_new_pr_qpth0013_20190626
Sep 17, 2019
Merged

{math}[foss/2019a] qpth v0.0.13_20190626 w/ Python 3.7.2#8665
boegel merged 4 commits intoeasybuilders:developfrom
smoors:20190803081835_new_pr_qpth0013_20190626

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Aug 3, 2019 •
edited by migueldiascosta
Loading

(created using eb --new-pr)
depends on #8662

@smoors smoors added the new label Aug 3, 2019
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Aug 3, 2019

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
nic408 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/6ace0f6650fc66984bc4fd096176f241 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Sep 12, 2019

closing and reopening to trigger travis

@easybuilders easybuilders deleted a comment from boegelbot Sep 12, 2019
@easybuilders easybuilders deleted a comment from boegelbot Sep 12, 2019
@easybuilders easybuilders deleted a comment from boegelbot Sep 12, 2019
@boegel boegel added this to the 4.x milestone Sep 12, 2019
boegel
boegel previously requested changes Sep 16, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/q/qpth/qpth-0.0.13_20190626-foss-2019a-Python-3.7.2.eb Outdated
'checksums': ['8de2c9e37959f3851f1e7b7475ab797d1de4ec3e825352cdde0fcd01ec1c7c67'],
}),
(name, version, {
'source_tmpl': '411c64f.tar.gz',
Copy link
Copy Markdown
Member

@boegel boegel Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be easy to overlook when updating this easyconfig...

Better use 'source_tmpl': '%s.tar.gz' % local_commit, here, and uncomment the commit = (and rename to local_commit = )?

Comment thread easybuild/easyconfigs/q/qpth/qpth-0.0.13_20190626-foss-2019a-Python-3.7.2.eb Outdated
easyblock = 'PythonBundle'

name = 'qpth'
version = '0.0.13_20190626'
Copy link
Copy Markdown
Member

@boegel boegel Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use - rather than _:

version = '0.0.13-20190626'

@smoors smoors dismissed boegel’s stale review September 17, 2019 09:22

changes done

boegel
boegel approved these changes Sep 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3121.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/531a9709845c0ff33937f1edf464f929 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node2629.swalot.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/1dc2a30025e5fc98d7e69302fde4ac2a for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2019

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in this PR)
node2065.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/d3a6ccb8d38d817858e4290f85390dbc for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2019

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/083c8a1c722a99623638bc5fc22fb2b2 for a full test report.

@boegel boegel modified the milestones: 4.x, 4.0.0 Sep 17, 2019
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 17, 2019

Going in, thanks @smoors!

@boegel boegel merged commit 6fa70b3 into easybuilders:develop Sep 17, 2019
@smoors smoors deleted the 20190803081835_new_pr_qpth0013_20190626 branch January 15, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@smoors @migueldiascosta @boegel