Skip to content

fix names of local variables in GCCcore and GCC easyconfigs#8682

Merged
vanzod merged 1 commit intoeasybuilders:4.xfrom
boegel:fix_local_var_naming_GCC
Aug 7, 2019
Merged

fix names of local variables in GCCcore and GCC easyconfigs#8682
vanzod merged 1 commit intoeasybuilders:4.xfrom
boegel:fix_local_var_naming_GCC

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 7, 2019

Required to avoid warnings being printed, because of changes made in easybuilders/easybuild-framework#2938

@boegel boegel added this to the 4.0 milestone Aug 7, 2019
@boegel boegel requested a review from vanzod August 7, 2019 16:59
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 7, 2019

Test report by @boegel
SUCCESS
Build succeeded for 54 out of 54 (54 easyconfigs in this PR)
node3142.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/dbfec3be024483d6822d6db37c7a30ef for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 7, 2019

The test report I've uploaded was done using eb --fetch, which should be sufficient (together with the passing tests) to confirm that no unintended changes were made here, since --fetch involves verifying the SHA256 checksums of sources/patches...

@vanzod vanzod merged commit 2b9a815 into easybuilders:4.x Aug 7, 2019
@boegel boegel deleted the fix_local_var_naming_GCC branch August 7, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants