Skip to content

fix names of local variables in h/*/*.eb easyconfigs#8720

Merged
Micket merged 1 commit intoeasybuilders:4.xfrom
boegel:fix_local_var_naming_h
Aug 14, 2019
Merged

fix names of local variables in h/*/*.eb easyconfigs#8720
Micket merged 1 commit intoeasybuilders:4.xfrom
boegel:fix_local_var_naming_h

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 9, 2019

required to avoid warnings when these easyconfigs are parsed because of changed made in easybuilders/easybuild-framework#2938

@boegel boegel added this to the 4.0 milestone Aug 9, 2019
@easybuilders easybuilders deleted a comment from boegelbot Aug 9, 2019
@boegel boegel force-pushed the fix_local_var_naming_h branch from 4b91b48 to 28c00ac Compare August 9, 2019 19:06
@boegel boegel force-pushed the fix_local_var_naming_h branch from 28c00ac to 89fe050 Compare August 9, 2019 19:46
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 9, 2019

Test report by @boegel
SUCCESS
Build succeeded for 43 out of 43 (43 easyconfigs in this PR)
node2012.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/e4eec6117f7eb8d3f7284dd7a2df687f for a full test report.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Aug 14, 2019

Going in, thanks @boegel!

@Micket Micket merged commit 3f283d3 into easybuilders:4.x Aug 14, 2019
@boegel boegel deleted the fix_local_var_naming_h branch August 15, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants