Skip to content

Add missing builddep for pkg-config to Gdk-Pixbuf.#8764

Merged
boegel merged 5 commits intoeasybuilders:3.9.xfrom
akesandgren:Gdk-Pixbuf-fix-missing-dep-for-pkg-config
Aug 22, 2019
Merged

Add missing builddep for pkg-config to Gdk-Pixbuf.#8764
boegel merged 5 commits intoeasybuilders:3.9.xfrom
akesandgren:Gdk-Pixbuf-fix-missing-dep-for-pkg-config

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

Also move GObject-Introspection to builddeps where appropriate.

Also move GObject-Introspection to builddeps where appropriate.
@akesandgren akesandgren added this to the next release (3.9.4?) milestone Aug 14, 2019
@akesandgren akesandgren requested a review from boegel August 14, 2019 07:04
@akesandgren akesandgren requested a review from pescobar August 14, 2019 09:21
@easybuilders easybuilders deleted a comment from boegelbot Aug 14, 2019
@easybuilders easybuilders deleted a comment from boegelbot Aug 14, 2019
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel removed the request for review from pescobar August 14, 2019 16:32
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 14, 2019

Test report by @boegel
FAILED
Build succeeded for 11 out of 12 (12 easyconfigs in this PR)
node2040.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a0b765efdd9463e5e6f221f17deea176 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 14, 2019

@akesandgren Gdk-Pixbuf-2.36.8-intel-2017a.eb fails now because the shared-mime-info is required now (pkg-config can't find it).

Can we avoid that requirement?

@akesandgren
Copy link
Copy Markdown
Contributor Author

Don't know. I'll try to get to test building of it soon.

@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Aug 15, 2019

Doesn't look like it. But shared-mime-info is something we should probably have as an osdep. There's just so much on a system that depends on it...

I wonder how these worked in the first place since missing pkg-config causes them to basically fail at configure_step, all of them...

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2019

Hmm, we actually have shared-mime-info-1.8-4.el7.x86_64 installed.

I'll check on it again, it shouldn't have failed (and yeah, I guess we should include shared-mime-info as an OS dep).

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 15, 2019

Or we build our own, it's a simple configure-make-make install, see https://freedesktop.org/wiki/Software/shared-mime-info/

@akesandgren
Copy link
Copy Markdown
Contributor Author

The problem with that is that it might make things point for mime to the EB tree only, and stuff won't see OS installed stuff. There's no clear and obvious path forward here that I can see.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 22, 2019

@akesandgren I just looked into the issue with shared-mime-info...

pkg-config --exists shared-mime-info fails because the system locations are not considered by the pkg-config we include as a build dep. We can fix that by adding the system locations via $PKG_CONFIG_PATH.

But in this particular case, the configure output gives the suggestion when the check for shared-mime-info failed to set $SHARED_MIME_INFO_LIBS and $SHARED_MIME_INFO_CFLAGS to avoid the need for using pkg-config to check for shared-mime-info.

The funny part is that both pkg-config --cflags shared-mime-info and pkg-config --libs shared-mime-info both yield nothing, so this works (not that those environment variables must be non-empty for this to work, so a single space is required):

preconfigopts = "export SHARED_MIME_INFO_LIBS=' ' SHARED_MIME_INFO_CFLAGS=' ' && "

Thoughts on including this too, perhaps even consistently across all these easyconfigs (even though only Gdk-Pixbuf-2.36.8-intel-2017a.eb actually shows this issue, for some reason unclear to me...

@akesandgren
Copy link
Copy Markdown
Contributor Author

All versions of 2.36 from .8, at least, and forward that i've looked at tries to find shared-mime-info. SO for those it does make sense.

I can take a look at that in a while.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 22, 2019

@akesandgren fixed with akesandgren#11

@boegel boegel changed the base branch from develop to 3.9.x August 22, 2019 16:53
…-config

avoid relying on pkg-config to check for shared-mime-info in Gdk-Pixb…
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 22, 2019

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (12 easyconfigs in this PR)
node2071.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/99eac6d40331fdac39e652323a753e76 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 22, 2019

Going in, thanks @akesandgren!

@boegel boegel merged commit 03f2c14 into easybuilders:3.9.x Aug 22, 2019
@akesandgren akesandgren deleted the Gdk-Pixbuf-fix-missing-dep-for-pkg-config branch August 23, 2019 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants