Skip to content

{chem}[foss/2019a,intel/2019a] ASAP3 v3.11.10, kim-api v2.1.2, openkim-models v20190725, ... w/ Python 3.7.2#8786

Merged
smoors merged 2 commits intoeasybuilders:developfrom
schiotz:20190816154541_new_pr_ASAP331110
Nov 15, 2019
Merged

{chem}[foss/2019a,intel/2019a] ASAP3 v3.11.10, kim-api v2.1.2, openkim-models v20190725, ... w/ Python 3.7.2#8786
smoors merged 2 commits intoeasybuilders:developfrom
schiotz:20190816154541_new_pr_ASAP331110

Conversation

@schiotz
Copy link
Copy Markdown
Contributor

@schiotz schiotz commented Aug 16, 2019

(created using eb --new-pr)

….11.10-intel-2019a-Python-3.7.2.eb, kim-api-2.1.2-foss-2019a.eb, kim-api-2.1.2-intel-2019a.eb, openkim-models-20190725-foss-2019a.eb, openkim-models-20190725-intel-2019a.eb, ASE-3.18.0-foss-2019a-Python-3.7.2.eb, ASE-3.18.0-intel-2019a-Python-3.7.2.eb and patches: ASAP3-3.11.10-Respect-CFLAGS-for-EasyBuild.patch
@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Aug 16, 2019

This makes ASAP3 available for the foss and intel 2019a toolchains. It also includes the newest KIM API and the OpenKIM models (ping @ellio167).

I have included the same version of ASE as in #8768 as otherwise the self-test would fail. Git should handle this duplication gracefully in the PR merged last.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 19, 2019

@schiotz I'm not a fan of changing software names. in any case it should be consistent.
I propose one of the following:
kim-api and kim-models,
KIM-API and KIM-MODELS, or
OpenKIM-API and OpenKIM-MODELS

@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Aug 19, 2019

Hi @smoors

I certainly see your point, but I think changing the names to be consistent with all other package managers should be done now, while there is not a bunch of software depending on it. So we avoid situations like the packages for Jupyter being called IPython because once upon a time that was the name.

The names kim-api and openkim-models are the names chosen by the developers, and used in other package managers. They distinguish between the KIM, which is an API specification (and an implementation of it) and OpenKIM which is one particular collection of KIM models, with many others being possible.

@ellio167 could you comment on this, please?

@ellio167
Copy link
Copy Markdown

Yes, what @schiotz says is correct.

We have been able to largely standardize the package names across system:
kim-api:
Packaging status

openkim-models:
Packaging status

As well as within https://github.com/spack/spack/tree/develop/var/spack/repos/builtin/packages/kim-api and https://github.com/spack/spack/tree/develop/var/spack/repos/builtin/packages/openkim-models

It seems desirable to have easybuild use the same names...

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 19, 2019

@schiotz ok, fair enough.

@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Aug 25, 2019

Closing and reopening to trigger new self-test (for EB 4.0).

@schiotz schiotz closed this Aug 25, 2019
@schiotz schiotz reopened this Aug 25, 2019
@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Nov 14, 2019

@boegel Can I do anything to get this one merged?

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schiotz the 2 ASE easyconfigs have already been merged, can you remove them?

@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Nov 15, 2019

@smoors Thank you for looking into it. I have removed the ASE configs (I though git handled that gracefully, but perhaps it would have introduced a change in the files). Next time I will avoid such duplication.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 15, 2019

Test report by @smoors
SUCCESS
Build succeeded for 9 out of 9 (6 easyconfigs in this PR)
node353.hydra.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/0ea9a9a8661e7f72fb7c36eacf1d42f0 for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 15, 2019

Going in, thanks @schiotz!

@smoors smoors merged commit 8f10b2b into easybuilders:develop Nov 15, 2019
('kim-api', '2.1.2'),
]

use_pip = False
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schiotz Just wondering, which issues did you run into with pip install that made you use use_pip = False here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asap installs a version of the python executable linked with MPI (called asap-python, needed for parallel simulations only), this does not get installed properly when using pip, since pip assumes it is a script, and tries to read the file and replace the hash-bang in the first line with the right path to the python executable. But since it is not a script but an executable, it goes wrong.

The main GPAW developer is working on fixing this in gpaw so building a special executable is not necessary, but there still seems to be problems on some combinations of architectures and MPI versions. Eventually, I am going to borrow his solution for asap, but it does require some work.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants