Skip to content

Patch out removed glibc 2.28 header from GCC libsanitizer in GCCcore 7.3.0 easyconfig#8789

Merged
smoors merged 1 commit intoeasybuilders:developfrom
zao:20190819093735_new_pr_GCCcore730
Aug 20, 2019
Merged

Patch out removed glibc 2.28 header from GCC libsanitizer in GCCcore 7.3.0 easyconfig#8789
smoors merged 1 commit intoeasybuilders:developfrom
zao:20190819093735_new_pr_GCCcore730

Conversation

@zao
Copy link
Copy Markdown
Contributor

@zao zao commented Aug 19, 2019

(created using eb --new-pr)
glibc 2.28 removed <sys/ustat.h>, this patch replaces use of the header with precomputed struct sizes needed by libsanitizer

@zao
Copy link
Copy Markdown
Contributor Author

zao commented Aug 19, 2019

This should address the problem on Fedora 30 mentioned in #8678.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 20, 2019

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
nic409 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/9c6f0a72fb31b4425f77f87ad4fbf741 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 20, 2019

@zao what about versions 8.2.0 and up ?

@zao
Copy link
Copy Markdown
Contributor Author

zao commented Aug 20, 2019

8.2.0 and 8.3.0 builds fine.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added the bug fix label Aug 20, 2019
@smoors smoors added this to the 3.9.4 milestone Aug 20, 2019
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 20, 2019

Going in, thanks @zao!

@smoors smoors merged commit f0ba5ba into easybuilders:develop Aug 20, 2019
@boegel boegel changed the title Patch out removed glibc 2.28 header from GCC libsanitizer Patch out removed glibc 2.28 header from GCC libsanitizer in GCCcore 7.3.0 easyconfig Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants