Skip to content

Adapt gzip's bundled gnulib for glibc 2.28#8791

Merged
smoors merged 1 commit intoeasybuilders:developfrom
zao:20190819124631_new_pr_gzip19
Aug 20, 2019
Merged

Adapt gzip's bundled gnulib for glibc 2.28#8791
smoors merged 1 commit intoeasybuilders:developfrom
zao:20190819124631_new_pr_gzip19

Conversation

@zao
Copy link
Copy Markdown
Contributor

@zao zao commented Aug 19, 2019

(created using eb --new-pr)
gzip ships an old version of gnulib that needs to be patched to work with Fedora 30's glibc 2.28.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 20, 2019

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
nic409 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/844080d1824c9cf4ac912d866794d1ef for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 20, 2019

@zao shouldn't this patch be added to gzip-1.10-GCCcore-8.2.0.eb as well?

@zao
Copy link
Copy Markdown
Contributor Author

zao commented Aug 20, 2019

Probably. I've limited my testing to foss/2018b and GCCcore/7.3.0 thus far.

@zao
Copy link
Copy Markdown
Contributor Author

zao commented Aug 20, 2019

@smoors The patch is not necessary for gzip/1.10, they have mitigated the problem and it builds fine for me.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added the bug fix label Aug 20, 2019
@smoors smoors added this to the 3.9.4 milestone Aug 20, 2019
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 20, 2019

Going in, thanks @zao!

@smoors smoors merged commit 09530d4 into easybuilders:develop Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants