Skip to content

use SYSTEM toolchain + fix local var names to fix broken tests after collapse of 4.x branch into develop#8822

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:fix_dummy_local_var_names
Aug 24, 2019
Merged

use SYSTEM toolchain + fix local var names to fix broken tests after collapse of 4.x branch into develop#8822
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:fix_dummy_local_var_names

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 23, 2019 •
edited
Loading

also requires easybuilders/easybuild-framework#2982 to make tests pass...

@boegel boegel added the bug fix label Aug 23, 2019
@boegel boegel added this to the 4.0.0 milestone Aug 23, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 23, 2019

Test report by @boegel
SUCCESS
Build succeeded for 12 out of 12 (12 easyconfigs in this PR)
node3101.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/ace8d8b86353b12af8209c4d11c0bd53 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Aug 23, 2019
@vanzod vanzod closed this Aug 23, 2019
@vanzod
Copy link
Copy Markdown
Member

vanzod commented Aug 23, 2019

Re-trigger Travis

@vanzod vanzod reopened this Aug 23, 2019
wpoely86
wpoely86 reviewed Aug 24, 2019
View reviewed changes
Comment thread easybuild/easyconfigs/p/PLINK/PLINK-2.00-alpha2-x86_64.eb
sources = ['plink2_linux_x86_64_20190810.zip']
checksums = ['009e9ae14aa821485b344846bfa46a8886e48f17b8feaa23c6a0360f61ea445f']

files_to_copy = [
Copy link
Copy Markdown
Member

@wpoely86 wpoely86 Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

Copy link
Copy Markdown
Member Author

@boegel boegel Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLINK is installed with PackedBinary, while files_to_copy is custom to MakeCp, so it's not actually used here at all...

Copy link
Copy Markdown
Member Author

@boegel boegel Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be removed here for the easyconfig tests to pass, since they now fail if local variables are used that don't follow the recommended naming scheme, see https://easybuild.readthedocs.io/en/4.x/Easyconfig-files-local-variables.html

akesandgren
akesandgren approved these changes Aug 24, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Aug 24, 2019

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 7ac24b6 into easybuilders:develop Aug 24, 2019
@boegel boegel deleted the fix_dummy_local_var_names branch August 24, 2019 11:26
This was referenced Aug 24, 2019
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpoely86 wpoely86 wpoely86 left review comments

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @vanzod @akesandgren @wpoely86