Skip to content

fix issue where 'print_qiime_config.py -t' sanity check command fails for QIIME 1.9.1 because of subdir missing in $PYTHONPATH#8838

Merged
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:QIIME_fix
Sep 12, 2019
Merged

fix issue where 'print_qiime_config.py -t' sanity check command fails for QIIME 1.9.1 because of subdir missing in $PYTHONPATH#8838
migueldiascosta merged 1 commit intoeasybuilders:developfrom
boegel:QIIME_fix

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Aug 26, 2019

It's unclear to me why we need to add site-packages to $PYTHONPATH now, and not before (see test reports in #3868)

@boegel
fix issue where 'print_qiime_config.py -t' sanity check command fails…
7bedf36 
… for QIIME 1.9.1 because of subdir missing in $PYTHONPATH
@boegel boegel added the bug fix label Aug 26, 2019
@boegel boegel added this to the 4.0.0 milestone Aug 26, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 26, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2661.swalot.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/7997c62ef804b4f1f015138d6e634a47 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 26, 2019

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2113.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/ec32685795f83c3a36db58308e24fc97 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Aug 26, 2019

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in this PR)
node3105.skitty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/592fd5ae4cfbd4b5c2d10c80220ebd74 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Sep 12, 2019

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2660 v4 @ 2.00GHz, Python 3.6.8
See https://gist.github.com/a8527405faccb596c8f0a0b28e9c4be9 for a full test report.

migueldiascosta
migueldiascosta approved these changes Sep 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Copy Markdown
Member

migueldiascosta commented Sep 12, 2019

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit c2d95ff into easybuilders:develop Sep 12, 2019
@boegel boegel deleted the QIIME_fix branch September 12, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @migueldiascosta